Fix roadheight field width #10175
Merged
Fix roadheight field width #10175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
bug
erictheise
added a commit
to OpenHistoricalMap/iD
that referenced
this pull request
Mar 22, 2024
… by cherry picking Minh's upstream pull request, openstreetmap#10175, and regenerating dist assets.
erictheise
added a commit
to OpenHistoricalMap/ohm-website
that referenced
this pull request
Mar 22, 2024
… by cherry picking Minh's upstream pull request, openstreetmap/iD#10175, and regenerating dist assets.
Recent versions of Firefox give input fields a greater intrinsic width that causes roadheight fields to overflow the container. Constrain these input fields to an initial width of zero; they’ll grow proportionally as part of the flexbox.
1ec5
force-pushed
the
1ec5-roadheight-flex-10174
branch
from
8bdfcaf to
f64e800
Compare
|
I tested this fix in Chrome 123, Firefox 125.0b3, and Safari 17.3.1 on macOS. |
tyrasd
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Firefox give input fields a greater intrinsic width that causes
roadheightfields to overflow the container. Constrain these input fields to an initial width of zero; they’ll grow proportionally as part of the flexbox.Fixes #10174.