Update help panel navigation buttons #10581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #105073 where the empty nav button for 'next' was overlapping the keyboard shortcuts button when the user was currently view the Quality Assurance page.
tyrasd
reviewed
Dec 4, 2024
css/80_app.css
Outdated
Comment on lines
4187
to
4190
| .ideditor .help-pane .nav::after { | ||
| content: ''; | ||
| display: table; | ||
| clear: both; |
There was a problem hiding this comment.
What is the purpose of this ::after block? In a quick test, for me the fix seems to work also without it.
There was a problem hiding this comment.
My mistake. I tried a clearfix hack first, but don't need it now the elements are floated instead. It's redundant now.
ForgottenHero
commented
Dec 5, 2024
css/80_app.css
Outdated
Comment on lines
4187
to
4190
| .ideditor .help-pane .nav::after { | ||
| content: ''; | ||
| display: table; | ||
| clear: both; |
There was a problem hiding this comment.
My mistake. I tried a clearfix hack first, but don't need it now the elements are floated instead. It's redundant now.
tyrasd
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10573 where the empty nav button for 'next' was overlapping the keyboard shortcuts button when the user was currently view the Quality Assurance page.