Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dropdown for suggestion of previous value of hashtags #10794

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

draunger
Copy link
Contributor

description

added the dropdown functionality in the hashtags field so that it can show previous value of hashtags used..

approach:

  • Extracted hashtags from recent changesets
  • Formatted them for dropdown: removed '#' for storage but kept it for display
  • Saved the original show function by using this => var origShow = hashtagField.show
  • Enhanced it to set up dropdown when field becomes visible
  • Preserved original behavior while adding new features
  • Used uiCombobox to create the dropdown functionality
  • Attached it to the input field when visible
  • Shows recent hashtags as suggestions

screenshot:

image

solves:

#10654

@draunger
Copy link
Contributor Author

@tyrasd i have added drop-down functionality as described in #10654 so , if you seem any issue you can please comment on that ..

@tyrasd tyrasd force-pushed the Suggest-previous-value-for-hashtag-field-like-comment branch from 728fdca to 3ca9886 Compare February 26, 2025 11:03
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit to simplify the code a bit and make it more readable. Maybe you want to give it a look to check if it still works as intended @draunger?

@draunger
Copy link
Contributor Author

draunger commented Feb 26, 2025

@tyrasd yes they are working as intended , sir can you tell me what did you have done to simplify this more, it will be very helpful for me for next time...

@k-yle k-yle linked an issue Feb 26, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest previous value for hashtag field like comment
2 participants