Embrace for-of

[hlfan]

Convert some for loops to for of loops to increase readability

[tyrasd]

Ususally I'm not the biggest fan of project-wide refactoring of single JS syntax features, for example because it will likely create merge conflicts with other open PRs/branches. Also, often the old code will typically have other stuff in dire need of a modernization as well.

That said, I think this does actually significantly bump the readability of the loops 💯 , and any potential merge conflicts should be quite easy to spot and resolve.

Only one thing: please don't use for (var foo of …) and choose either const or let instead, depending on the situation at hand.

[hlfan]

There's much more possible that I didn't include, for now I only regex-replaced the loop heads when the index wasn't needed, including copying the declarations.
for ?\(((?:var|let|const) )?([^\s,=;]+) ?= ?0; ?\2 ?< ?([^\s,=;]+)\.length; ?\2?\+\+\2?\) ?\{\n\s+((?:var|let|const) )?([^\s,=;]+) ?= ?\3\[\2\];
for ($4$5 of $3) {
Therefore, I didn't take a closer look at var/let/const and also because I want to keep merge conflicts easily fixable.

[tyrasd]

ok, I see. Then let's not do it this way.