Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fire-station icon for fire-hydrant #3380

Merged
merged 1 commit into from
Aug 28, 2016
Merged

Conversation

bagage
Copy link
Contributor

@bagage bagage commented Aug 27, 2016

Fire hydrants are for firemen anyway, and it help distinguish them from other no-icon point on the map.

By the way, is there any plan to upgrade maki from version 0.5.0 to latest version 2.0.x? Is that OK if I migrate iD by updating icons' name or there is a particular reason to use maki 0.5.0?

Fire hydrants are for firemen anyway, and it help distinguish them from other no-icon point on the map. 

By the way, is there any plan to upgrade maki from version 0.5.0 to latest version 2.0.x? Is that OK if I migrate iD by updating icons' name or there is a particular reason to use maki 0.5.0?
@bhousel
Copy link
Member

bhousel commented Aug 28, 2016

By the way, is there any plan to upgrade maki from version 0.5.0 to latest version 2.0.x? Is that OK if I migrate iD by updating icons' name or there is a particular reason to use maki 0.5.0?

I'd like to upgrade to maki2, but there's a bit of work for us to be able do this. see #3024, #3025
Because it uses different icon sizes, it's not a drop in replacement. We have a bunch of places in the iD code that pick the right icon and construct a name with the right size (e.g. it turns fire-station into fire-station-12, fire-station-18, or fire-station-24).

@bhousel bhousel merged commit a6f6bb9 into openstreetmap:master Aug 28, 2016
@bagage
Copy link
Contributor Author

bagage commented Aug 28, 2016

Ooooh, it looks like a considerable work actually! I subscribed to these issues to keep track of any progress here (and for any get-started label if any!). Thanks @bhousel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants