Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "castle_type" field to castle preset #3685

Merged
merged 1 commit into from
Dec 28, 2016
Merged

Add "castle_type" field to castle preset #3685

merged 1 commit into from
Dec 28, 2016

Conversation

abdeldjalil09
Copy link
Contributor

No description provided.

@abdeldjalil09
Copy link
Contributor Author

sorry

@bhousel
Copy link
Member

bhousel commented Dec 27, 2016

You don't have to close it, it's a good start..

@abdeldjalil09 abdeldjalil09 reopened this Dec 27, 2016
@bhousel bhousel merged commit b074c29 into openstreetmap:master Dec 28, 2016
@bhousel
Copy link
Member

bhousel commented Dec 28, 2016

Thanks, I cleaned it up and merged! File needed to be named castle_type.json, and had some formatting issues.

It looks like you might be trying to edit the code directly in GitHub. I definitely recommend following the steps in README.md (see Prerequisites and Installation sections) to set up a local environment to test iD and edit the files that way. It is actually easier to work on iD presets that way, rather than using the online editor. Let me know if you need help or get stuck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants