Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed a raw tag editor on the commit pane #3898

Merged
merged 4 commits into from
Mar 15, 2017
Merged

Embed a raw tag editor on the commit pane #3898

merged 4 commits into from
Mar 15, 2017

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Mar 13, 2017 •
edited
Loading

This will let users add and edit changeset tags before saving.
re: #2834, #2633

  • The raw tag editor will always start out closed in this case.
  • No taginfo support for changeset tags, so dropdowns and tag autocompletion are disabled
  • TODO: The default iD tags will be protected and not allow editing.

changeset_tags

@bhousel bhousel added the wip Work in progress label Mar 13, 2017
@runnabot
Copy link

Deployed iD-runnable/changeset-tags. View on Runnable.
From Runnable

@bhousel
Changeset refactor
1a8cfcc 
(closes #2633)

* move osmChangeJXON from osm service to osmChangeset
* cleanup putChangeset for code clarity
* adjust params for callbacks (pass changeset around instead of changeset_id)
* add commit.reset() to reset changeset object after successful save
* improve checks for changeset tags (trim whitespace, etc)
@bhousel bhousel merged commit 2200b67 into master Mar 15, 2017
@bhousel bhousel deleted the changeset-tags branch March 15, 2017 19:02
@bhousel bhousel removed the wip Work in progress label Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhousel @runnabot