Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requesting review #4223

Merged
merged 32 commits into from
Aug 17, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
b5ece16
add requesting review
kepta Jul 24, 2017
e22c379
Merge branch 'master' into request_review
bhousel Aug 10, 2017
e52fcdb
Move the rest of the RTL rules to be next to the rules they override
bhousel Aug 10, 2017
03c8e07
Remove the link to the osm wiki changeset page
bhousel Aug 10, 2017
9bba0ed
Move request review up next to comment
bhousel Aug 11, 2017
1a9614b
Adjust styles
bhousel Aug 11, 2017
b172b46
Move review_requested back to the buttons.. Make it work on tag changes
bhousel Aug 11, 2017
59e6642
Pacify eslint
bhousel Aug 11, 2017
439eed4
WIP: refactor uiCommit into sections, introduce uiChangesetEditor
bhousel Aug 11, 2017
e0266da
WIP: add changeset fields and refactor
bhousel Aug 12, 2017
fba6871
WIP: persist uiRawTagEditor, uiChangesetEditor between renders
bhousel Aug 13, 2017
78e874d
Allow fields to work w/o entity, add options to disable buttons
bhousel Aug 14, 2017
9b37ac7
Fix errors with changeset fields and warnings, improve styles
bhousel Aug 14, 2017
4971a20
Pacify eslint
bhousel Aug 14, 2017
347177f
Restore placeholders
bhousel Aug 14, 2017
e6eff90
Restore the previous changeset dropdown
bhousel Aug 14, 2017
194b56c
Restore the comment google warning
bhousel Aug 15, 2017
d7a0720
Restore saving comment to localstorage
bhousel Aug 15, 2017
ba3f823
Split out commitWarnings and commitChanges sections into smaller modules
bhousel Aug 15, 2017
7563f3a
Refactor duplicate form-field code to uiFormFields
bhousel Aug 15, 2017
09a661c
Restore "good changeset comments" link in tag-reference section
bhousel Aug 15, 2017
c56dc5a
In save mode, escape should cancel and return to browse mode
bhousel Aug 15, 2017
e990971
Change source field to semiCombo, let users pick common source types
bhousel Aug 15, 2017
746b54f
Make combo field work without an entity
bhousel Aug 15, 2017
df16568
Change hashtags field to semiCombo
bhousel Aug 15, 2017
4cf357f
Add code to extract hashtags from changeset comment
bhousel Aug 16, 2017
a42aa78
Add hashtags API parameter and localStorage
bhousel Aug 16, 2017
8cb04a0
Track walkthrough progress in localStorage
bhousel Aug 16, 2017
25d8a8a
Store changesets_count in a changeset tag
bhousel Aug 16, 2017
ea298b0
Change raw tag editor readOnlyTags to accept array of regex
bhousel Aug 16, 2017
2bf7a5e
Write changeset tags for new mappers to indicate walkthrough progress
bhousel Aug 17, 2017
121a1fa
Avoid making an empty `hashtags` tag
bhousel Aug 17, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 29 additions & 24 deletions API.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,43 +8,48 @@ iD supports several URL parameters. When constructing a URL to a standalone inst
of iD (e.g. `http://preview.ideditor.com/release/`), the following parameters are available
in the hash portion of the URL:

* `map` - A slash separated `zoom/latitude/longitude`. Example:
`map=20.00/38.90085/-77.02271`
* `id` - The character 'n', 'w', or 'r', followed by the OSM ID of a node,
* __`map`__ - A slash separated `zoom/latitude/longitude`.<br/>
_Example:_ `map=20.00/38.90085/-77.02271`
* __`id`__ - The character 'n', 'w', or 'r', followed by the OSM ID of a node,
way or relation, respectively. Selects the specified entity, and, unless
a `map` parameter is also provided, centers the map on it.
* `background` - The value from a `sourcetag` property in iD's
* __`background`__ - The value from a `sourcetag` property in iD's
[imagery list](https://github.com/openstreetmap/iD/blob/master/data/imagery.json),
or a custom tile URL. A custom URL is specified in the format `custom:<url>`,
where the URL can contain the standard tile URL placeholders `{x}`, `{y}` and
`{z}`/`{zoom}`, `{ty}` for flipped TMS-style Y coordinates, and `{switch:a,b,c}` for
DNS multiplexing. Example:
`background=custom:https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png`
* `gpx` - A custom URL for loading a gpx track. Specifying a `gpx` parameter will
automatically enable the gpx layer for display. Example:
`gpx=https://tasks.hotosm.org/project/592/task/16.gpx`
* `offset` - imagery offset in meters, formatted as `east,north`. Example:
`offset=-10,5`
* `comment` - Prefills the changeset comment box, for use when integrating iD with
external task management or quality assurance tools. Example:
`comment=CAR%20crisis%2C%20refugee%20areas%20in%20Cameroon%20%23hotosm-task-592`.
* `rtl=true` - Force iD into right-to-left mode (useful for testing).
* `walkthrough=true` - Start the walkthrough automatically
DNS multiplexing.<br/>
_Example:_ `background=custom:https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png`
* __`gpx`__ - A custom URL for loading a gpx track. Specifying a `gpx` parameter will
automatically enable the gpx layer for display.<br/>
_Example:_ `gpx=https://tasks.hotosm.org/project/592/task/16.gpx`
* __`offset`__ - imagery offset in meters, formatted as `east,north`.<br/>
_Example:_ `offset=-10,5`
* __`comment`__ - Prefills the changeset comment. Pass a url encoded string.<br/>
_Example:_ `comment=CAR%20crisis%2C%20refugee%20areas%20in%20Cameroon`
* __`hashtags`__ - Prefills the changeset hashtags. Pass a url encoded list of event
hashtags separated by commas, semicolons, or spaces. Leading '#' symbols are
optional and will be added automatically. (Note that hashtag-like strings are
automatically detected in the `comment`).<br/>
_Example:_ `hashtags=%23hotosm-task-592,%23MissingMaps`
* __`rtl=true`__ - Force iD into right-to-left mode (useful for testing).
* __`walkthrough=true`__ - Start the walkthrough automatically

##### iD on openstreetmap.org (Rails Port)

When constructing a URL to an instance of iD embedded in the OpenStreetMap Rails
Port (e.g. `http://www.openstreetmap.org/edit?editor=id`), the following parameters
are available as regular URL query parameters:

* `map` - same as standalone
* `lat`, `lon`, `zoom` - Self-explanatory.
* `node`, `way`, `relation` - Select the specified entity.
* `background` - same as standalone
* `gpx` - same as standalone
* `offset` - same as standalone
* `comment` - same as standalone
* `walkthrough` - same as standalone
* __`map`__ - same as standalone
* __`lat`__, __`lon`__, __`zoom`__ - Self-explanatory.
* __`node`__, __`way`__, __`relation`__ - Select the specified entity.
* __`background`__ - same as standalone
* __`gpx`__ - same as standalone
* __`offset`__ - same as standalone
* __`comment`__ - same as standalone
* __`hashtags`__ - same as standalone
* __`walkthrough`__ - same as standalone


## CSS selectors
Expand Down
Loading