Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New help texts #4468

Closed
wants to merge 94 commits into from
Closed

New help texts #4468

wants to merge 94 commits into from

Conversation

manfredbrandl
Copy link
Contributor

I give it a fresh try.

@manfredbrandl
Copy link
Contributor Author

@bhousel please review. Some java-script is not perfect.

data/core.yaml Outdated

### Saving Edits
othereditors: |
### Other Editors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this soon.

@bhousel
Copy link
Member

bhousel commented Oct 24, 2017

It overall looks really good! I think what you did with the JavaScript is fine.

Is this still work in progress or are you mostly finished? When you are all done, I'd like to have a few more people look it over (especially inexperienced users) for ideas on things we could simplify.

@manfredbrandl
Copy link
Contributor Author

@bhousel It is mostly finished, and of course I will remove the section about other editors. Please let a few people look on it, a native speaker would help, ideas for simplification or missing information, etc. would help now.

@manfredbrandl
Copy link
Contributor Author

@bhousel I did some more polishing. Did anybody look over it?

@bhousel
Copy link
Member

bhousel commented Oct 31, 2017

I did some more polishing. Did anybody look over it?

Sorry @manfredbrandl not yet - I am trying to pull in a bunch of other things and do a release soon, then we will merge this one which will affect the translations significantly.

(I've been giving priority to the PRs that are closing Hacktoberfest issues, since for some people this is their credit for the promotion).

@manfredbrandl
Copy link
Contributor Author

@bhousel no problem, the text needs a native speaker and a osm newbie to look over. i am happy to have that merged soon after the next release to give translators enough time till the following release.

bhousel and others added 21 commits November 16, 2017 00:43
added common fields for preset amenity=telephone
Wiki makes no mention of it being specifically a "news" kiosk, describing it instead as selling various things. Is this country-specific usage?
Between keyboard shortcuts screen and onscreen hover text, I think we have
the icons covered well enough and don't need to add it to the help.  Having
it in help means that translators need to do double work.
@manfredbrandl
Copy link
Contributor Author

@bhousel is now time for review or merge?

@bhousel
Copy link
Member

bhousel commented Nov 22, 2017

is now time for review or merge?

@manfredbrandl yes! I started yesterday making my edits. I probably would have merged it last night but I got tired.. basically:

  • simplified the language, borrowing from the tutorial language wherever possible
  • simplify the topics to "points","lines","areas", instead of "points & addresses", "lines & roads", "areas & buildings" (although I did keep in the mapping guidance about how to map addresses, roads, and buildings in those sections)
  • added section on street level photos like Mapillary and OpenStreetCam
  • removed the section that listed out the icons (mostly because all the icons already have hovertips, and I don't want to risk having this help section go stale)

I still need to clean up the section on Relations, but I expect to merge it today and talk it up on Twitter to get people translating the content.

Thank you again for all your work on this @manfredbrandl - the new help is sooo much better 🙇 Having it broken up into smaller sections will help translators a lot!

@manfredbrandl
Copy link
Contributor Author

@bhousel I really appreciate having you improvements on my text. I hope to have enought time tommorow to translate to German, otherwise someone else will do it during my vacation.

@bhousel bhousel mentioned this pull request Nov 22, 2017
@bhousel
Copy link
Member

bhousel commented Nov 22, 2017

Moved to #4557... Excited to be close to merging this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants