-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New help texts #4468
New help texts #4468
Conversation
@bhousel please review. Some java-script is not perfect. |
data/core.yaml
Outdated
|
||
### Saving Edits | ||
othereditors: | | ||
### Other Editors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove this soon.
It overall looks really good! I think what you did with the JavaScript is fine. Is this still work in progress or are you mostly finished? When you are all done, I'd like to have a few more people look it over (especially inexperienced users) for ideas on things we could simplify. |
@bhousel It is mostly finished, and of course I will remove the section about other editors. Please let a few people look on it, a native speaker would help, ideas for simplification or missing information, etc. would help now. |
@bhousel I did some more polishing. Did anybody look over it? |
Sorry @manfredbrandl not yet - I am trying to pull in a bunch of other things and do a release soon, then we will merge this one which will affect the translations significantly. (I've been giving priority to the PRs that are closing Hacktoberfest issues, since for some people this is their credit for the promotion). |
@bhousel no problem, the text needs a native speaker and a osm newbie to look over. i am happy to have that merged soon after the next release to give translators enough time till the following release. |
(closes #4441)
todo: Need to figure out API issue with bbox, then imageviewer
add preset for music schools
added common fields for preset amenity=telephone
Wiki makes no mention of it being specifically a "news" kiosk, describing it instead as selling various things. Is this country-specific usage?
Kiosk name update
…anfredbrandl-new-help
Between keyboard shortcuts screen and onscreen hover text, I think we have the icons covered well enough and don't need to add it to the help. Having it in help means that translators need to do double work.
@bhousel is now time for review or merge? |
@manfredbrandl yes! I started yesterday making my edits. I probably would have merged it last night but I got tired.. basically:
I still need to clean up the section on Relations, but I expect to merge it today and talk it up on Twitter to get people translating the content. Thank you again for all your work on this @manfredbrandl - the new help is sooo much better 🙇 Having it broken up into smaller sections will help translators a lot! |
@bhousel I really appreciate having you improvements on my text. I hope to have enought time tommorow to translate to German, otherwise someone else will do it during my vacation. |
Moved to #4557... Excited to be close to merging this 🙌 |
I give it a fresh try.