Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preset for allotments=plot. #4920

Merged
merged 2 commits into from
Mar 21, 2018

Conversation

vershwal
Copy link
Collaborator

This PR adds preset for allotments=plot.
Related #4917.

@bhousel
Copy link
Member

bhousel commented Mar 21, 2018

Thanks @vershwal!
From reading the wiki page, I think this preset is supposed to be its own feature, not combined with landuse=allotments.

so move:
data/presets/presets/landuse/allotments/plot.json
to
data/presets/presets/allotments/plot.json

..and remove all references to landuse in that file. It should just set the allotments=plot tag by itself.

"key": "allotments",
"value": "plot"
},
"name": "Plot"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the name to "Community Garden Plot".. This is how it would be called in en-US, which we use as the source language.

@vershwal
Copy link
Collaborator Author

Hey @bhousel!!
Thanks for reviewing. I have made the required changes. Please check.

@bhousel
Copy link
Member

bhousel commented Mar 21, 2018

Perfect @vershwal - thanks again!

@bhousel bhousel merged commit 7f82572 into openstreetmap:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants