Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update d3 to the latest version 🚀 #4929

Closed
wants to merge 1 commit into from
Closed

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 22, 2018

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 5.0.0 of d3 was just published.

Dependency d3
Current Version 4.13.0
Type devDependency

The version 5.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of d3.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes 5.0.0

D3 now includes new categorical color schemes from ColorBrewer, along with ColorBrewer’s excellent diverging, sequential single-hue and sequential multi-hue color schemes. The twenty-color schemes were removed because their grouped design often falsely implied non-existent relationships in the data: a shared hue can imply that the encoded data are part of a group (a super-category), while the relative lightness can falsely imply order.

Commits

The new version differs by 11 commits ahead by 11, behind by 2.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@bhousel
Copy link
Member

bhousel commented Mar 23, 2018

It will probably be a while before we can take this upgrade, due to d3-request being deprecated. We will likely need to polyfill in both Fetch and Promise APIs if we want to continue to support IE11. (see current browser stats)

Full v5 changelog: https://github.com/d3/d3/blob/master/CHANGES.md

greenkeeper bot added a commit that referenced this pull request Apr 16, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Apr 16, 2018

Version 5.0.1 just got published.

Update to this version instead 🚀

Release Notes v5.0.1
Commits

The new version differs by 11 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Apr 17, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Apr 17, 2018

Version 5.0.2 just got published.

Update to this version instead 🚀

Release Notes v5.0.2
Commits

The new version differs by 2 commits.

See the full diff

greenkeeper bot added a commit that referenced this pull request Apr 18, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Apr 18, 2018

Version 5.1.0 just got published.

Update to this version instead 🚀

Release Notes v5.1.0
Commits

The new version differs by 2 commits.

See the full diff

@bhousel
Copy link
Member

bhousel commented Apr 24, 2019

I'm working on this today. The main hurdle so far is swapping out d3-request for d3-fetch.

Today I learned that fetch was not abortable until somewhat recently, so we will need this AbortController polyfill so that our service code can continue to abort unneeded requests. This is a thing that can happen a lot as the user scrolls and iD requests data tiles, or when the user switches connection between prod<->dev osm servers.

@bhousel
Copy link
Member

bhousel commented Apr 27, 2019

this has moved to #6245

@bhousel bhousel closed this Apr 27, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/d3-5.0.0 branch April 29, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant