Code

Notes#5107

Code

Merged

bhousel merged 86 commits intomasteropenstreetmap/iD:masterfrom notesopenstreetmap/iD:notesCopy head branch name to clipboardJul 16, 2018

+1,909-307

Commits

Commits on Jun 19, 2018

• init commit: updated locales/en after build

  thomas-hervey

  committed
  f92bc63

• added: .vscode debug config to ignore

  thomas-hervey

  committed
  e3c0fd4

• added: map data notes toggle

  thomas-hervey

  committed
  1ed915e

• reformatted svg/notes

  thomas-hervey

  committed
  3de1fd8

• added: notes api service, parse and callback stubs

  thomas-hervey

  committed
  cf2a9ad

Commits on Jun 20, 2018

• added: svg notes, TODO: add icon, test

  thomas-hervey

  committed
  3df01e2

Commits on Jun 21, 2018

• updated: fixed services/notes function declarations

  thomas-hervey

  committed
  473570c

• added: .vscode to .gitignore

  thomas-hervey

  committed
  47ef49d

• merged from master

  thomas-hervey

  committed
  db0fe7e

• cleaned: extraneous details in notes

  thomas-hervey

  committed
  4576100

• added: first test (failing)

  thomas-hervey

  committed
  e16b411

Commits on Jun 22, 2018

• updated: notes rendering

  thomas-hervey

  committed
  dab46d2

Commits on Jun 23, 2018

• remove console.log, change icon

  thomas-hervey

  committed
  1878397

Commits on Jun 25, 2018

• updated: notes svg to prevent duplicate appending

  thomas-hervey

  committed
  0859d00

Commits on Jun 29, 2018

• updated: siebar displays note details on hover (via svg)

  thomas-hervey

  committed
  737ccfc

Commits on Jun 30, 2018

• merged: services/notes into /osm; todo: fix some caching & rendering

  thomas-hervey

  committed
  b3f7b06

• Merge branch 'master' into notes

  bhousel

  committed
  9517635

• Merge remote-tracking branch 'origin/merge_notes_service' into notes

  bhousel

  committed
  d034691

• Fix the osmNote initializer

  bhousel

  committed
  fd1d2f0

• Add update method, remove getters..

  Show description for ede5610
  bhousel

  committed
  ede5610

• delete: demo select file (unintentional commit)

  thomas-hervey

  committed
  1b06dbd

• Cleanup osm service notes and caches, remove state variable

  Show description for 229484a
  bhousel

  committed
  229484a

• Draw 2x icons (shadow and fill) so they stand out more

  bhousel

  committed
  2f8efee

• updated: pull from remote

  thomas-hervey

  committed
  eba9bde

• updated: notes caching

  thomas-hervey

  committed
  dcef114

• Move note css from the photos.css into a new css file data.css

  bhousel

  committed
  bcc1669

• Update css styles for notes

  Show description for f3d31f3
  bhousel

  committed
  f3d31f3

Commits on Jul 1, 2018

• Better spinner event management

  Show description for 487ec9d
  bhousel

  committed
  487ec9d

• updated: Premium DigitalGlobe description

  thomas-hervey

  committed
  9fc94f5

• updated: pull from remote

  thomas-hervey

  committed
  fc4d800

Commits on Jul 2, 2018

• Don't add notes to the _seenEntity cache

  Show description for 00c8ff4
  bhousel

  committed
  00c8ff4

• Move tests to spec/services/osm.js and remove old notes.js files

  bhousel

  committed
  535208b

• Adjust green

  bhousel

  committed
  65b2a42

• Add some dots if there is a comment thread

  bhousel

  committed
  13a30c0

• Remove unused far-comment-alt icon

  bhousel

  committed
  3304cc8

• pulled updates from remote

  thomas-hervey

  committed
  5b4dde0

• updated: hacky note hovering; todo: complete note click handling

  thomas-hervey

  committed
  2c22fe0

• merged: icon update from remote

  thomas-hervey

  committed
  d81b9c5

• Working on note editor style and ui, simplify d3 code

  bhousel

  committed
  a474e3b

• Merge, continue to tweak note_editor

  bhousel

  committed
  94eae89

• updated: new comments in notes sidebar ui

  thomas-hervey

  committed
  86dc0c9

• Add getNode and replaceNote methods, refactor caches

  bhousel

  committed
  7999aca

• updated: reintroduced hovering on notes

  thomas-hervey

  committed
  bd8705b

• If notes are coincident, move them apart slightly

  bhousel

  committed
  2d2845e

Commits on Jul 3, 2018

• Adjust pointer css for note markers

  Show description for d87a2c2
  bhousel

  committed
  d87a2c2

• Switch innerHtml to textContent, which properly unescapes xml

  Show description for e0cc626
  bhousel

  committed
  e0cc626

• Playing with note styling, add avatars and more metadata

  bhousel

  committed
  ab8e793

• merged from remote

  thomas-hervey

  committed
  b4c6607

• updated: notes save buttons

  thomas-hervey

  committed
  61ae541

• added checks for multiclick and click on notes

  thomas-hervey

  committed
  8121f58

• resolve conflicts, fix a few minor bugs prob caused by merging:

  Show description for b14d1b5
  bhousel

  committed
  b14d1b5

• Restore modeSelect, and make a new modeSelectNote just for the notes

  bhousel

  committed
  bf499d9

Commits on Jul 4, 2018

• fixed select_note mode, cleaned note_editor, TODO: enable note save

  thomas-hervey

  committed
  73ee5c2

• Add user method to osm service, _userCache, user parser

  bhousel

  committed
  6f1dc12

Commits on Jul 5, 2018

• Add code to swap in avatar images for users that have them

  bhousel

  committed
  263ec9e

Commits on Jul 6, 2018

• Linkify the usernames

  bhousel

  committed
  01b33e3

Commits on Jul 7, 2018

• Add "More/Less" toggle for too long comments (curr limit 600 chars)

  bhousel

  committed
  d137aa0

Commits on Jul 8, 2018

• Combine Osm and Notes layers into the same ul

  bhousel

  committed
  3eb3eef

• pacify some eslint warnings

  bhousel

  committed
  7b42743

• updated: removed centering when clicking a note

  thomas-hervey

  committed
  0f49514

• WIP: toggle note status

  thomas-hervey

  committed
  14356ce

Commits on Jul 9, 2018

• fixed typo

  thomas-hervey

  committed
  c460c03

Commits on Jul 10, 2018

• WIP: update service calls; todo: note update event handling

  thomas-hervey

  committed
  eafae6c

Commits on Jul 11, 2018

• Refactor out uiNoteHeader and uiNoteComments into separate modules

  Show description for 0d7c292
  bhousel

  committed
  0d7c292

• Implement multi-fetch get for users from OSM API

  Show description for 7423d19
  bhousel

  committed
  7423d19

• Add noteOptions, default to 10k note limit and 7 days closed

  Show description for f52f24b
  bhousel

  committed
  f52f24b

• Style note header

  bhousel

  committed
  e9e2f9b

• Drop more/less toggle and just use a scrollbar for long comments

  bhousel

  committed
  3454753

Commits on Jul 12, 2018

• WIP on buttons, simplify, remove some event dispatch

  Show description for 91add0c
  bhousel

  committed
  91add0c

• Store the unsaved comment in the note itself

  bhousel

  committed
  5e5601f

• Add header close 'X' button, add grey hover styling

  bhousel

  committed
  fe7086f

• Properly save and restore caches when entering/leaving the walkthrough

  bhousel

  committed
  19560eb

Commits on Jul 13, 2018

• Add docs about OSM API, finish implementing postNoteUpdate

  Show description for 645cc79
  bhousel

  committed
  645cc79

• Implement note save button code

  bhousel

  committed
  57da729

• Remove from inflight cache before doing anything in done

  bhousel

  committed
  775b472

• Update notes on status change

  bhousel

  committed
  8a1079c

• Can't skip seen on the userDetails call

  Show description for f825845
  bhousel

  committed
  f825845

• added tests for notes service

  thomas-hervey

  committed
  bd15865

• Wrap callbacks with common checks for connection id and auth failure

  Show description for 33ef9a4
  bhousel

  committed
  33ef9a4

• Make uiViewOnOSM work for notes too, add it to note_editor footer

  bhousel

  committed
  1a106f5

• added note reporting and margin to save buttons

  thomas-hervey

  committed
  7fb42ac

Commits on Jul 16, 2018

• added simple tests for loading and retrieving notes

  thomas-hervey

  committed
  7ad765d

• fixed note-report display

  thomas-hervey

  committed
  33de399

• Cleaner note icon rendering

  Show description for 70f8763
  bhousel

  committed
  70f8763

• Make sure note report link doesn't show on hover

  bhousel

  committed
  47de7b3

• Add thread dots to note header icon, disable comments on closed nodes

  bhousel

  committed
  694cc60