Update map directional indicator based off of current bearing in MapillaryJS viewer #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, I like the bearing indicator for the panoramic images! But I ended up restoring the display of viewfields for the non-selected images. I tried using the Mapillary layer without them, and I thought it was just too frustrating not knowing which direction an image would be pointed until I actually clicked on it. I get that the viewfields are kind of visual clutter, but 1. they are only shown at z18 and higher, and 2. the solution to visual clutter in iD can be "just zoom in more until it's not a problem". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also leaves visible the directional indicator only for the current image