Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Carport preset #5353

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Add Carport preset #5353

merged 1 commit into from
Oct 1, 2018

Conversation

Stormheg
Copy link
Contributor

Fixes #5339 #5339

@bhousel
Copy link
Member

bhousel commented Oct 1, 2018

Thanks @Stormheg - looks good to me 👍

@bhousel
Copy link
Member

bhousel commented Oct 1, 2018

By the way, in the future if you are able to do so, it's great to npm run build after changing a preset file.. This will check for errors and rebuild the generated files.. It's your first time so don't worry about it - I'll run the command on my end.

@bhousel bhousel merged commit 29de881 into openstreetmap:master Oct 1, 2018
@Stormheg Stormheg deleted the fix/issue-5339 branch October 1, 2018 15:57
@Stormheg
Copy link
Contributor Author

Stormheg commented Oct 1, 2018

Thanks @bhousel I didn't know that I had to commit the generated files. Will do so next time!

@bhousel bhousel mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stormheg @bhousel