New Piste presets #5368
Merged
New Piste presets #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2018 14:53
…culty and grooming keys.
|
Related to issue #5354 |
quincylvania
requested changes
Oct 4, 2018
There was a problem hiding this comment.
Hi @yvecai, thanks for doing this! A few things:
- I like the specialized keys, but I suggest we keep a generic Piste preset matching the tag
"piste:type": "*"for generic features. - Go ahead and remove the
piste_prefix from the preset filenames, since they are already categorized underpiste/. For example, changepresets/piste/piste_downhilltopresets/piste/downhill. - Instead of organizing the fields under the name of the preset they correspond to, categorize them based on the key. If you have different fields for the same key, add a suffix. This may also let you reuse some fields. For example, change
fields/piste_sleigh/difficulty.jsontofields/piste/difficulty.jsonand also use it for the sled preset, and then changefields/piste_skitour/difficulty.jsontofields/piste/difficulty_skitour.json - The wiki page discourages using
piste:typeon nodes, so please delete thepointgeometry.
It'll be great to have these additions once we work out the kinks! Thanks again!
|
Thank you for reviewing, all this make sense. I will make those changes in a few days. |
|
Commit 3296176 should cover it all. |
|
Ah, sorry for this last minute change, I forgot to have a look at relations. |
|
Looks great, thanks @yvecai 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preset associated with piste:type=* tag is split into the various piste:type values (downhill, nordic, skitour, sled, etc ...).
This allow a more sensible description of the piste:difficulty=* and piste:grooming:* subtags as their meaning depends on the type of activity.