Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds highlighting of relation members in the map when hovering on their list item #5402

Merged

Conversation

quincylvania
Copy link
Collaborator

@quincylvania quincylvania commented Oct 14, 2018

This lets users see what feature the member refers to before selecting it, reducing the need for guessing.

ezgif-1-ae0af1a4c3b9

@quincylvania quincylvania self-assigned this Oct 14, 2018
@bhousel
Copy link
Member

bhousel commented Oct 14, 2018

Nice, looks good to me..
I wonder if it might even be better if the shadow was a little more obvious, like how we style the shadows in the turn restrictions editor. Are there situations where the selected feature is pulsing and so you can't see the highlight on the relation member?

also +1 for screenshot of Philly

@quincylvania
Copy link
Collaborator Author

Now that you mention it, if the relation is a multipolygon then all the lines are pulsing and you couldn't see the member highlighting. I'll try adding a more prominent style that works in both situations.

I'm originally from Philly!

@quincylvania
Copy link
Collaborator Author

I updated the hover styling to use the link color and be more opaque. It now also works with multipolygons.

screen shot 2018-10-13 at 11 05 35 pm

screen shot 2018-10-13 at 10 57 12 pm

@bhousel
Copy link
Member

bhousel commented Oct 14, 2018

This looks pretty great! Thanks @quincylvania 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants