Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for some rtl issues #5704

Merged
merged 2 commits into from
Jan 13, 2019
Merged

fix for some rtl issues #5704

merged 2 commits into from
Jan 13, 2019

Conversation

iriman
Copy link
Contributor

@iriman iriman commented Jan 13, 2019 •
edited
Loading

fix for #5705 and second part of #5687

@bhousel
Copy link
Member

bhousel commented Jan 13, 2019

Thanks again @iriman !

By the way, for stuff like the membership editor heading section, it's usually ok and a bit simpler to switch the original padding rule to something like padding: 0 10px (padding on both sides) instead of adding a rtl rule with padding-right to override the original padding-left. What you did is ok too 👍

@bhousel bhousel merged commit 14fc2c8 into openstreetmap:master Jan 13, 2019
@bhousel bhousel mentioned this pull request Jan 13, 2019
Closed
@iriman
Copy link
Contributor Author

iriman commented Jan 14, 2019

Ah yes 👍 thanks

@iriman iriman deleted the rtl-issues--iriman branch January 14, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iriman @bhousel