Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets for golf paths and cartpaths and driving ranges #5862

Merged
merged 7 commits into from
Feb 7, 2019
+118 −4
Merged

Presets for golf paths and cartpaths and driving ranges #5862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7955bc
Presets for golf paths and cartpaths
chadrockey Feb 5, 2019
d3afa94
Add driving range preset
chadrockey Feb 5, 2019
0bc5c13
Cleanup according to comments
chadrockey Feb 5, 2019
c34f010
Remove golf tags
chadrockey Feb 5, 2019
25cc522
Update to avoid connectivity errors
chadrockey Feb 6, 2019
31a5264
Add Golf Cartpath Multipurpose
chadrockey Feb 6, 2019
90115b5
Update track to service
chadrockey Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions data/presets/categories.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"building/residential"
]
},
"category-golf": {
"category-golf-area": {
"icon": "maki-golf",
"geometry": "area",
"name": "Golf Features",
Expand All @@ -40,7 +40,19 @@
"golf/rough",
"golf/bunker",
"golf/tee",
"golf/water_hazard_area"
"golf/water_hazard_area",
"golf/driving_range"
]
},
"category-golf-line": {
"icon": "maki-golf",
"geometry": "line",
"name": "Golf Features",
"members": [
"golf/hole",
"golf/cartpath",
"golf/cartpath_multipurpose",
"golf/path"
]
},
"category-landuse": {
Expand Down
3 changes: 2 additions & 1 deletion data/presets/categories/golf.json → data/presets/categories/golf-area.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"golf/rough",
"golf/bunker",
"golf/tee",
"golf/water_hazard_area"
"golf/water_hazard_area",
"golf/driving_range"
]
}
11 changes: 11 additions & 0 deletions data/presets/categories/golf-line.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"icon": "maki-golf",
"geometry": "line",
"name": "Golf Features",
"members": [
"golf/hole",
"golf/cartpath",
"golf/cartpath_multipurpose",
"golf/path"
]
}
23 changes: 23 additions & 0 deletions data/presets/presets/golf/cartpath.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"icon": "maki-golf",
"fields": [
"name",
"surface",
"width",
"structure",
"access",
"incline"
],
"geometry": [
"line"
],
"tags": {
"golf": "cartpath",
"golf_cart": "designated"
},
"reference": {
"key": "golf",
"value": "cartpath"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reference page for golf=cartpath
https://taginfo.openstreetmap.org/tags/golf=cartpath

If you're inventing this tag, please reconsider.

A more normal way of nesting OSM tags might look like:
highway=path+path=golf_cart
or
highway=track+track=golf_cart+tracktype=grade1

},
"name": "Golf Cartpath"
}
24 changes: 24 additions & 0 deletions data/presets/presets/golf/cartpath_multipurpose.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"icon": "maki-golf",
"fields": [
"name",
"surface",
"width",
"structure",
"access",
"incline"
],
"geometry": [
"line"
],
"tags": {
"highway": "service",
"golf": "cartpath",
"golf_cart": "designated"
},
"reference": {
"key": "golf",
"value": "cartpath"
},
"name": "Golf Cartpath Multipurpose"
}
18 changes: 18 additions & 0 deletions data/presets/presets/golf/driving_range.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"icon": "maki-golf",
"fields": [
"name"
],
"geometry": [
"area"
],
"tags": {
"golf": "driving_range",
"landuse": "grass"
},
"reference": {
"key": "golf",
"value": "driving_range"
},
"name": "Driving Range"
}
23 changes: 23 additions & 0 deletions data/presets/presets/golf/path.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"icon": "maki-golf",
"fields": [
"name",
"surface",
"width",
"structure",
"access",
"incline"
],
"geometry": [
"line"
],
"tags": {
"golf": "path",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same stuff applies here as I said on the cartpath preset above..

It should probably be highway=path + path=golf

"foot": "designated"
},
"reference": {
"key": "golf",
"value": "path"
},
"name": "Golf Walking Path"
}
4 changes: 3 additions & 1 deletion data/taginfo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,11 @@
{"key": "entrance", "description": "🄿 Entrance/Exit, 🄵 Type", "object_types": ["node"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/entrance-alt1-15.svg?sanitize=true"},
{"key": "ford", "value": "yes", "description": "🄿 Ford", "object_types": ["node"]},
{"key": "natural", "value": "sand", "description": "🄿 Sand Trap, 🄿 Sand", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "landuse", "value": "grass", "description": "🄿 Fairway, 🄿 Rough, 🄿 Tee Box, 🄿 Grass", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "landuse", "value": "grass", "description": "🄿 Fairway, 🄿 Rough, 🄿 Tee Box, 🄿 Driving Range, 🄿 Grass", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "sport", "value": "golf", "description": "🄿 Putting Green", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "golf", "value": "hole", "description": "🄿 Golf Hole", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "golf", "value": "cartpath", "description": "🄿 Golf CartPath", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "golf", "value": "path", "description": "🄿 Golf Walking Path", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "natural", "value": "water", "description": "🄿 Lateral Water Hazard, 🄿 Water Hazard, 🄿 Water", "object_types": ["area"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "golf", "value": "lateral_water_hazard", "description": "🄿 Lateral Water Hazard", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
{"key": "golf", "value": "water_hazard", "description": "🄿 Water Hazard", "object_types": ["way"], "icon_url": "https://raw.githubusercontent.com/mapbox/maki/master/icons/golf-15.svg?sanitize=true"},
Expand Down