Handle multiple tags when splitting up in tag editor

[AndreasHae]

As requested by @tordans in #5070 and #6185:

When pasting multiple tags like "amenity=restaurant name=The Restaurant", they shall be split up and added separately. My implementation assumes that there will never be spaces in keys, so it also handles cases like "name=The Restaurant amenity=restaurant" correctly, and splits it up at the last space before the key.

[AndreasHae]

Huh, seems like the build system complains about missing semicolons, although they are present.

[bhousel]

Huh, seems like the build system complains about missing semicolons, although they are present.

You need to put them in the anonymous functions too.. for example:

list.map(function(item) { return item.trim(); });

[tordans]

@AndrewHain <3

Will it also work if I copy multi line key-value pairs which are something like key=value\nkey2=value2 (\n meaning "however JS "sees" a line break). (I am bad at reading regex.)

[AndreasHae]

Oh, thanks @bhousel! Didn't see them.. What's weird though is that the build passed just fine for me locally.

[AndreasHae]

@tordans yes, that works!

[quincylvania]

What's weird though is that the build passed just fine for me locally.

@AndreasHae You need to run npm run lint to see some syntax errors like missing semicolons that the build and mocha tests won't catch.

[slhh]

@AndreasHae
Assuming no spaces in keys seems to be ok, but in addition you are likely assuming no equal signs in values, which could for example fail in case of URLs, conditional restrictions (operators =, <=, >=), strange names. I think a space is insufficient to separate tags.

[AndreasHae]

Good point @slhh.
Do you think I should limit the splitting only to newlines?

[bhousel]

Thanks @AndreasHae - this looks ok 👍