convert terms back to array on transifex import [Suggestion] #6298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be a slight improvement from a data structure point of view to convert the
terms
back from a comma separated string to an array already during the import from transifex.So, the actual iD code does not convert it back but it is already in the right form to consume. Also, it is more consistent to have the
terms
as an array in the localization files because it is also an array in thepresets.json
. (Was confused about this)What do you think?
The localizations need to be re-generated if this is merged.