Enable field editing in multiselection #7306
Conversation
…#7276) Add `utilCombinedTags` method and use it for the raw tag editor as well as fields Pass `entityIDs` array into fields instead of single `entity` object Give field revertion its own path separate from `change` Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
There was a problem hiding this comment.
I’m having a lot of fun playing around with this branch!
If I select two features that are different geometries (like a line and a node), the only available feature types are all barriers. Not sure why that is, since there are other presets that apply to multiple geometries.
If I select multiple features, and the name of one of them is locked due to a wikidata tag, the Name field remains editable and affects all the selected features. I’m not sure if it would be too annoying to lock the field as soon as one of the selected features has a locked name, or if it would be too surprising that editing the field would silently skip any locked names.
If I select two features that have issues, the issues aren’t visible. I realize this PR is focused on the fields, but maybe some validator warnings like the one for fixme are useful with multiple selection.
|
@1ec5 Thanks for testing! 📏
Hmm you mean when changing the preset? I'm not seeing this. The default list is lacking right now but more options show up when you start searching.
We should probably lock the field if any feature has Wikidata since it'd be pretty bad to override the name of an important place in a multiselection by accident.
It does sound confusing for any features to get skipped for any field. Let's try to avoid this.
Yep, I'd like to enable an issues section too, but that's future work! |
Oh you’re right, I was just confused by the initial list. |
|
This feature can now be tested on our |
Closes #7276.
Been working on this for a week and it's really shaping up. I wouldn't want to ship multiselection raw tag editing without also enabling it fields, since iD mappers are discouraged from editing raw tags anyway.
Each field now has a "mixed" state which indicates that more than one value exists between all the features in the selection. The values are listed in the tooltip when hovering over the input. When features of different presets are selected, only fields common to all of them are shown.
I'm certain this feature will be a big time saver, especially coupled with repeat drawing in iD v3!
Fields still to support:
localizedradio