Fix a lot of typos and initial codespell action run #7752
Conversation
Untested, only checked by inspection.
| @@ -4,5 +4,5 @@ | |||
| "reference": { | |||
| "key": "healthcare" | |||
| }, | |||
| "label": "Specialties" | |||
| "label": "Specialities" | |||
There was a problem hiding this comment.
I assume because it's a label this is a safe change?
There was a problem hiding this comment.
Label changes are okay if needed, but Specialties is the common American spelling for this and is intentional.
There was a problem hiding this comment.
Oops, fixed in Codespell in codespell-project/codespell@ed89a55 .
Okay undone @quincylvania , although it's rather mixed messages being in a British English file with a US English Label, or is that covered by further translation?
There was a problem hiding this comment.
So British English is the default for OSM's tags, while US English is the default for iD's interface. This causes lots of these types of mismatches in the preset files. Kerb/curb, groyne/groin, centre/center, etc.
There was a problem hiding this comment.
Oh dear, that's entertaining!
peternewman
changed the title
quincylvania
added
the
chore
|
Hi @quincylvania , How do you want to progress with this? Is it worth me for example pulling out all the fixes in readme files and comments, or all the stuff overall I've committed so far to get that merged, and then working separately on the remaining bits codespell is reporting until the action is green. Or narrow the scope of codespell to just the stuff that already passes. |
|
Bump @quincylvania ? I see #7845 has gone in since. |
|
@peternewman Sorry for the delay, I've been on a volunteer basis for the past month or so and haven't had time to consider this. It sounds fine to pull out the markdown and comment fixes and we can merge them right in. The code and data changes would take more attention. |
See #7892 when you get a chance then. |
| @@ -4,5 +4,5 @@ | |||
| "reference": { | |||
| "key": "healthcare" | |||
| }, | |||
| "label": "Specialties" | |||
| "label": "Specialities" | |||
There was a problem hiding this comment.
Label changes are okay if needed, but Specialties is the common American spelling for this and is intentional.
Undo an errant edit
|
I think this is ready for re-review now. |
Most of these are probably genuine typos. A few may be legitimate that don't need fixing.
I'll try and work through some soon.See here if it doesn't show up in the PR action:
https://github.com/peternewman/iD/runs/816084284?check_suite_focus=true