NSI related fixes #8618
Merged
NSI related fixes #8618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll only _replace_ the tag value if this tag is the toplevel/defining tag for the matched item (`k`) (closes #8615)
mbrzakovic
approved these changes
Aug 2, 2021
| @@ -349,6 +349,7 @@ function gatherNames(tags) { | |||
| } | |||
|
|
|||
| function isNamelike(osmkey, which) { | |||
| if (osmkey === 'old_name') return false; | |||
There was a problem hiding this comment.
Perhaps a small detail but it would be cleaner to include this to 'notNames' exception list
There was a problem hiding this comment.
I thought about that but notNames is already a pretty gnarly regex and I didn't want to make it worse.
10 tasks
This was referenced Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8615 - preserve tag values that can be toplevel tags unless it's the toplevel tag for the matched item
closes #8617 - don't consider
old_nameas a name for matching