Remove -alt-long name match for S/T Chinese
#8751
Conversation
Remove those part of code, because only 2 kind of Chinese have `-alt-long` , other language only have `-alt-menu` so I think this will not affected other language in the future.
| @@ -92,11 +92,6 @@ exports.languageNamesInLanguageOf = function(code) { | |||
| }); | |||
|
|
|||
| for (let langCode in translatedLangsByCode) { | |||
| let altLongIndex = langCode.indexOf('-alt-long'); | |||
| if (altLongIndex !== -1) { // prefer long names (e.g. Chinese -> Mandarin Chinese) | |||
There was a problem hiding this comment.
Looks like this logic was introduced in #6702. I don’t know the reasoning, but I agree that it’s incorrect in the context of OSM tagging. There are cases where it’s necessary to distinguish between written Mandarin Chinese and written Cantonese (Yue), but it’s a lot rarer than in text-to-speech, and name:zh would probably contain the non-Cantonese variant. Technically, OSM could make this distinction using name:cmn and name:yue, respectively, but name:cmn is very rare.
There was a problem hiding this comment.
Actually we Chinese seldom distinguish what the written form called, and "zh-Hans" is a script. Not only China use Simplified Chinese, Singapore also use this varient script.
If must say some thing is "Mandarin" in pronunciation, let this distinguish in "cmn" or "yue" extlang. That‘s where “Mandarin” can be use.
So even if we don't care about the translated name of CLDR is what, it is still unnecessary to choose a name with "-long" when display "name:xx" in OSM ( Especially the zh in OSM data have different means defined by the location)
Further:
http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
There was a problem hiding this comment.
So I am more concerned about the difficulty of this PR being merged/rejected 😭
According to #8739 , this part of code import unproper translation for S/T Chinese.
Remove those part of code, because only 2 kind of Chinese have
-alt-long, other language only have-alt-menuso I think this will not affected other language in the future.Close #8739