Object history preservation improvements #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
added
the
enhancement
tyrasd
reviewed
Dec 6, 2021
There was a problem hiding this comment.
Wow, what a great PR. Huge thanks! 🙇
My only question/remark would be if it was really necessary to introduce the mew method osmEntity.id.isNew(id) in addition to osmEntity.isNew(). I don't immediately see why there would be a need for both methods. Wouldn't it be sufficient for this PR to simply call isNew() on the respective entity objects directly?
tyrasd
added
the
priority
Depending on which way is the longest, the new way is inserted into the relation before the existing one. This case must be explicitly handled for the relation to remain correct.
tpetillon
force-pushed
the
history_preservation
branch
from
bab4b76 to
3ff06f9
Compare
|
You’re right, it wasn’t needed! I didn’t realise that while cleaning the code. I have removed it, and rebased the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends what has been done in #7795 and #8708. It improves object ID preservation in the following cases:
To help doing this, the PR adds some utility functions dealing with object IDs.
It also fixes the order of relation members in some cases when splitting ways. (Depending on which way was the longest after the split, the two ways resulting from the split action could be inserted in the wrong order in the relation.)
Tests are provided for these actions.