Fix incorrect Google validation warnings when viewing esri Africa buildings #8844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angesets with the approved google africa building dataset.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If viewing areas that include buildings from the ESRI africa building dataset, folks might see a validation error declaring 'Google products are proprietary and must not be used as references'. This validation does NOT apply to the Africa buildings dataset since it is licensed correctly and approved for use in OSM.
Related RapiD issue: facebook/Rapid#403:
Image with the validation:
This fix adds a small exception to the regex and a quick test to ensure it's correct.