Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render diameter when a feature is selected #9732

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Jul 6, 2023

If a node has a tag like diameter or radius, iD will now render a circle when you select the node.

image

  • As per the wiki, spaces are allowed between the number and the unit.
  • These tags are supported: diameter, diameter_crown, hole:diameter, radius, crown_radius, and seamark:anchor_berth:radius.
  • Many different units of measurement are supported, including a combination of feet and inches
  • The default unit is m for all tags except diameter, where the default unit is mm and seamark:anchor_berth:radius where the unit is defined by a separate tag (seamark:anchor_berth:units)

Outstanding issues:

  • A separate PR will be required to add a field to the "Turning Circle" preset (and possibly the tree preset for diameter_crown?)
  • There is a problem with the way selection.selectAll is used, which causes the rendering to stop after certain options like the Extract operation

@tordans
Copy link
Collaborator

tordans commented Sep 5, 2024

I really like this idea. We are using diameter on trees a lot in Neukölln to render a more realistic Map like https://strassenraumkarte.osm-berlin.org/?map=micromap#19/52.47378/13.43892 so that will help at lot to get a feel for this value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants