Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Preset for historic=millstone #1067

Open
Mitsjol opened this issue Dec 6, 2023 · 4 comments · May be fixed by #1419
Open

Add Preset for historic=millstone #1067

Mitsjol opened this issue Dec 6, 2023 · 4 comments · May be fixed by #1419
Labels
good first issue Good for newcomers new-preset

Comments

@Mitsjol
Copy link

Mitsjol commented Dec 6, 2023 •
edited by tyrasd
Loading

OSM Tag(s)

historic=millstone

How would you like this tag to see supported?

As a Preset

Label

Millstone

Aliases

N/A

Terms

grindstone, quernstone, quern, grinding stone, grinding wheel, mill wheel

Link to OSM Wiki page

https://wiki.openstreetmap.org/wiki/Tag:historic=millstone

Status of the Tag

Approved

Usage of the tag

63 (2024-02-05)

Replaces other Tag?

no

Regional Tag?

global

Further Information

No response
@Mitsjol Mitsjol added the enhancement New feature or request label Dec 6, 2023
@tyrasd tyrasd added new-preset and removed enhancement New feature or request labels Feb 5, 2024
tyrasd added a commit that referenced this issue Feb 5, 2024
@tyrasd
add option "millstone" to field for the historic tag (see #1067)
2f24b91 
see https://wiki.openstreetmap.org/wiki/Tag:historic=millstone
@tyrasd
Copy link
Member

tyrasd commented Feb 5, 2024 •
edited
Loading

Usage is currently still pretty low with less than 100 occurrences in OSM. But given that these features are probably relatively rare in general, but are still typically quite significant local landmarks, I'd say a preset for these should be added.

As a first step, I have now added an translatable option to select the value millstone in the Type field of the generic Historic Site preset.

@tyrasd tyrasd added the good first issue Good for newcomers label Feb 5, 2024
@anmolchhabra21
Copy link

can I start working on this issue?

1 similar comment
@anmolchhabra21

This comment was marked as duplicate.

Sign in to view
@tyrasd
Copy link
Member

tyrasd commented Feb 17, 2024

surely, go ahead @anmolchhabra21

priyanshubajaj added a commit to priyanshubajaj/id-tagging-schema that referenced this issue Jan 5, 2025
@priyanshubajaj
Did Add Preset for historic=millstone openstreetmap#1067
25dc2d8 
Added the preset for OSM tag historic = millstone via adding a millstone.json file with the tags in accordance with the wiki page
@priyanshubajaj priyanshubajaj linked a pull request Jan 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers new-preset
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closing issue #1067 by adding preset for historic = millstone priyanshubajaj/id-tagging-schema
3 participants
@tyrasd @Mitsjol @anmolchhabra21