Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert deprecation of amenity=dancing_school #373

Closed
tyrasd opened this issue Jan 28, 2022 · 3 comments
Closed

Revert deprecation of amenity=dancing_school #373

tyrasd opened this issue Jan 28, 2022 · 3 comments
Labels
bug Something isn't working deprecating

Comments

@tyrasd
Copy link
Member

tyrasd commented Jan 28, 2022

See openstreetmap/iD#6251 (comment) and following comments.

This would involve the following changes:

  • drop the deprecation of amenity=dancing_school
  • change the "Dance School" preset to use amenity=dancing_school as its tag
  • (optional) add a field to indicate that a "Dance Hall" also offers lessons (dance:teaching=yes)
@matkoniecz
Copy link
Contributor

@simonpoole
Copy link

General remark: could we be somewhat more conservative with "deprecating" stuff in general (in this case it was always clearly wrong). There is no agreed on process for deprecating tags, which does not mean that it is never a good idea, but simply something snuck in to a tagging proposal should not be enough. See also https://www.openstreetmap.org/user/Mateusz%20Konieczny/diary/398555#comment51838

@mnalis
Copy link
Contributor

mnalis commented Mar 11, 2023

@tyrasd tyrasd closed this as completed in 2e88d1b Mar 13, 2023
@tyrasd tyrasd changed the title Consider removing deprecation of amenity=dancing_school Revert deprecation of amenity=dancing_school Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deprecating
Projects
None yet
Development

No branches or pull requests

4 participants