-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate amenity=dancing_school #6251
Conversation
Also deprecated in the wiki and a replacement is available, see https://wiki.openstreetmap.org/wiki/Tag%3Aamenity%3Ddancing_school
Thanks for all your contributions today @westnordost 👏 |
A facility providing professional dancing instruction may be co-located with a dancing hall, but just as well could be completely separate depending on the audience and scope (for example providing vocational education). Just because somebody engaged in wiki-fiddling is no reason to jump to conclusions. |
Okay, so the concept is that Then let's revert this and make the dancing school a preset and somebody should clear up the wiki. |
Dance Hall has been a preset since 2016, see #3579 and I followed the recommendation on the wiki at the time. Dance school has been a preset since 2018, see #4846. The contributor followed the recommendation on the wiki at the time. I agree that the wiki could use some cleanup, but we don't need to revert anything. We are following the guidelines the best we can, and we don't need multiple presets for Dance Halls - it's totally fine to deprecate the |
I think this is about the name. Sure, you may get tuition at a dancing venue, but this doesn't make the dancing venue a dancing school. For example, a car dealership Whether this is really about that, I am not sure, because the wiki is not really clear here. But at least it would make sense this way and would be consistent. Edit: Also in size. Dancing schools may often be only a small-ish room as big as a yoga-room or dojo, while I would imagine that a dancing venue/hall (don't know any) would be a bigger thing. |
openstreetmap/id-tagging-schema#373 proposes revert of that PR |
openstreetmap/id-tagging-schema#1177 (comment) actually reverts it, I made broken PR |
Also deprecated in the wiki and a replacement is available, see https://wiki.openstreetmap.org/wiki/Tag%3Aamenity%3Ddancing_school