Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amenity=kneipp_water_cure with subtags #866

Closed
tordans opened this issue Apr 13, 2023 · 4 comments
Closed

Add amenity=kneipp_water_cure with subtags #866

tordans opened this issue Apr 13, 2023 · 4 comments

Comments

@tordans
Copy link
Collaborator

tordans commented Apr 13, 2023

OSM Tag(s)

amenity=kneipp_water_cure

How would you like this tag to see supported?

As a Preset

Label

Kneipp facility

Aliases

Maybe Hydrotherapy?

Terms

No response

Link to OSM Wiki page

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dkneipp_water_cure

Status of the Tag

Approved

Usage of the tag

2,200

Replaces other Tag?

No

Regional Tag?

Could be Germany and Austria, see https://taginfo.openstreetmap.org/tags/amenity%3Dkneipp_water_cure#map

Further Information

Not a too much usage but something I want to map but have to look up every time I see it.

The additional fields are quite useful, but have little usage, yet.

@tordans tordans added the enhancement New feature or request label Apr 13, 2023
@tyrasd tyrasd added new-preset and removed enhancement New feature or request labels Apr 13, 2023
@tyrasd
Copy link
Member

tyrasd commented Apr 13, 2023

there already exists a preset: amenity/kneipp_water_cure.json and field: fields/kneipp_water_cure_multi.json for this tag & subtags. see openstreetmap/iD#7332

The field is missing translatable strings and the preset could use some terms / aliases, but otherwise it should be already quite usable…

@tyrasd tyrasd added question Further information is requested and removed new-preset labels Apr 13, 2023
@tordans
Copy link
Collaborator Author

tordans commented Apr 15, 2023

Thanks! Don't know why I did not see it before 🤷 :).

The terms look good at https://app.transifex.com/openstreetmap/id-editor/translate/#de/presets/192709229?q=key%3Akneipp_water_cure.

Found a small issue in GoMap that was reported and fixed (no values showed for the :arm … sub-tags).

We could think about adding a custom Icon like suggested in https://wiki.openstreetmap.org/wiki/File:Kneipp_water_cure.svg, but thats not worth the effort for just 2k items IMO. => Closing this issue.

@tordans tordans closed this as completed Apr 15, 2023
@tordans
Copy link
Collaborator Author

tordans commented Apr 17, 2023

Reopening this after talking to @bryceco. Right now, the multiCombo https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/kneipp_water_cure_multi.json does not list keys, so it relies on taginfo lists. Which is an issue, since the keys have little use, so they fall below a threshold to be visible.

An easy fix would be to add "foot", "arm" as explicit strings like in

"strings": {
"options": {
"electricity": "Electricity",
"hot_water": "Hot Water",
"hot_air": "Hot Air",
"cold_water": "Cold Water",
"cold_air": "Cold Air",
"compressed_air": "Compressed Air",
"steam": "Steam",
"vacuum": "Vacuum"
}
},
for example. (I would only add those two, since they are actually "in use".

kneipp_water_cure:foot – 800
kneipp_water_cure:arm – 400
kneipp_water_cure:face – just 40 https://taginfo.openstreetmap.org/keys/kneipp_water_cure%3Aface#overview
kneipp_water_cure:cold_affusion – just 10 https://taginfo.openstreetmap.org/keys/kneipp_water_cure%3Acold_affusion#overview

@tordans tordans reopened this Apr 17, 2023
@tyrasd tyrasd added new-value and removed question Further information is requested labels Apr 17, 2023
@tyrasd tyrasd closed this as completed in 9971ed0 Apr 17, 2023
@tordans
Copy link
Collaborator Author

tordans commented Apr 18, 2023

Thanks a lot, @tyrasd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants