#1016 Create bicycle_wash.json (amenity=bicycle_wash) #1032
Conversation
First attempt to add the new tagging scheme to iD
|
@mcliquid ideally ask to add the icon to be added at https://github.com/rapideditor/temaki/issues which makes it easy to integrate here. |
|
@tordans Thank you! I've added a PR here: rapideditor/temaki#88 |
|
The PR has been merged: rapideditor/temaki#88 |
|
@tyrasd As far as I can see, you need to start the workflows so that they can run through and we can merge that PR, right? |
|
🍱 Preview the tagging presets of this pull request here: https://pr-1032--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
|
@mcliquid cool idea. However, I would really prefer if such a previously undocumented and not high usage tag would go through some kind of community vetting process first before it is included in iD's presets. This could be in the form of a wiki tag proposal process, or a reasonably equivalent discussion in the community. |
tyrasd
added
the
waitfor-discussion
|
@tyrasd Thanks, Proposal is under way: https://wiki.openstreetmap.org/wiki/Proposal:Bicycle_Wash I can ping here again when it's voted. |
tyrasd
force-pushed
the
1016-amenity-bicycle_wash
branch
from
9d70282 to
3cd65ec
Compare
|
@tyrasd The Proposal has been accepted: https://wiki.openstreetmap.org/wiki/Proposal:Bicycle_Wash |
|
@tyrasd Anything else missing? |
tyrasd
removed
the
waitfor-discussion
|
@mcliquid: thank you and no: this PR looks great now. |
|
PS: it seems like the proposal already brought a bit of traction/visibility to the tag: |
Fix for #1016
First attempt to add the new tagging scheme to iD. This is my very first pull request here, so feel free to share what needs to be improved.
The current icon in the PR is from FontAwesome, as I've seen it that way in other PRs, but there would also be a custom icon that would fit better. How to mark this one?
https://wiki.openstreetmap.org/wiki/File:Bicycle_wash.svg