Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add presets for cycleway=traffic_island #1068

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Dec 7, 2023

Closes #950

No one commented on that issue so I assume this is non-controversial...

Here's the updated table, the 2 entries marked as 🆕 are the ones added in this PR:

Foot Cycle Cycle & Foot
Roadside Path ✅ Sidewalk ✅ Cycle Path ✅ Cycle & Foot Path
Generic Crossing ✅ Pedestrian Crossing ✅ Cycle Crossing ✅ Cycle & Foot Crossing
Specific Crossings ✅ Unmarked Crossing
✅ Marked Crossing
✅ Uncontrolled Crossing
✅ Zebra Crossing
✅ Crossing With Traffic Signals
✅ Unmarked Cycle Crossing
✅ Marked Cycle Crossing
✅ Uncontrolled Cycle Crossing

✅ Cycle Crossing With Traffic Signals




Traffic Island ✅ Refuge Island 🆕 Cycle Refuge Island 🆕 Cycle & Foot Refuge Island

Cycle & Foot Refuge Island is hidden in the same countries as the existing preset Cycle & Foot Path

Copy link

github-actions bot commented Dec 7, 2023

🍱 Preview the tagging presets of this pull request here: https://pr-1068--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tyrasd tyrasd added this to the v6.6 milestone Dec 15, 2023
@tyrasd tyrasd modified the milestones: v6.6, v6.7 Jan 24, 2024
@tyrasd tyrasd modified the milestones: v6.7, v6.8 Mar 13, 2024
Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also add a (unsearchable) preset for path=traffic_island https://wiki.openstreetmap.org/wiki/Tag:path=traffic_island which has low usage ATM but it is a pain to hot have all those crossing presents on all common highway classes and for some tagging the hw=path+bicycle=designated+foot=designated is very common.

Comment on lines +26 to +35
"locationSet": {
"exclude": [
"fr",
"lt",
"pl",
"de",
"il",
"ps"
]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved to the top to sync it with data/presets/highway/cycleway/bicycle_foot.json.

@tordans tordans mentioned this pull request Apr 26, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 2 more presets for refuge islands
3 participants