-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create preset for kitchen garden #1135
Conversation
🍱 You can preview the tagging presets of this pull request here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok. I'd only like to see this tag value been described on the wiki; at least as an entry on the table for the garden:type
tag key. Once that's done, this preset can be added here as well.
Thanks, you're right, I've added the type to the table. |
@tyrasd I double checked the preview and there are two fields which doesn't make sense in this case ("Allowed access" and "Fee"). Is there a way to remove them by default? |
May I point out that kitchen was/is a (semi-documented) value for garden:style not garden:type, the numbers would further indicate that the 1'300 occurrences are simply a mis-tagging and should be corrected to garden:style This PR would seem to be creating unnecessary divergent tagging. |
Thanks Simon, I completely missed that. I do agree that the use of the more common and previously documented tag is better. //edit: fixed in 9505676 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are presets for "residential" and "community" garden:type (#714). This one adds a preset for kitchen garden. Like the others, it's a de facto tag with some usages (> 1200), see the original proposal.