-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Document about roles, people and processes #1230
Conversation
🍱 You can preview the tagging presets of this pull request here. |
In https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file#supported-file-types the suggested name for this file is
I think this fits what we are trying to do here so I think we should use this name. |
MAINTENANCE.md
Outdated
|
||
### PR Reviews and Merges | ||
|
||
- PRs need approval from two people: the author and one more contributors before being merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- PRs need approval from two people: the author and one more contributors before being merged. | |
- PRs need approval from two people: the author and one or more contributors before being merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other ways to amend this. BTW, is "contributor" requiring any experience/presence? Past accepted PR? It is kind of unclear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, is "contributor" requiring any experience/presence? Past accepted PR? It is kind of unclear
I just added a very high level section to handle the question how the defined roles are assigned https://github.com/openstreetmap/id-tagging-schema/pull/1230/files#diff-87a0c4623bffa64c60b62a39eeab1c40bd0f329cebc177f5e4492555fb5d42aeR68-R73
This does not go into details on which criteria are used to make this decision which is IMO fine because in the absence of published criteria it is clear IMO that the person responsible for the step will have to make a judgement decision.
Ping @tyrasd
Co-authored-by: Mateusz Konieczny <matkoniecz@gmail.com>
Just to clarify: all comments I made here are not statement/request/official communication of any organization. And it is just my regular, hopefully useful, nitpicking/debugging. |
to avoid confusion with "regular" contributors, and to better represent the great value these people add to the project also, a few other small amendments to clarify the roles
Co-authored-by: Tobias <t@tobiasjordans.de>
@tyrasd following our conversation on the last iD community call I created this draft of a separate document that gives more visibility on who is doing what in this repository and how some of the core processes are strucutres.
This is not as fleshed out as #1229, especially the process part. But a good way to improve this will be using it and changing it over time, I think.
In this document I changed my role to the contributor role which I still offer to do.
Parts of this are inspired by https://github.com/streetcomplete/StreetComplete/blob/master/AUTHORS.md – thanks a lot