Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for office=translator #1298

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

deevroman
Copy link
Contributor

@deevroman deevroman marked this pull request as ready for review July 26, 2024 12:38
@Zverik
Copy link
Collaborator

Zverik commented Jul 26, 2024

I endorse this. Saw dozens of translation offices in Tallinn, but had to use office=company for those because didn't know of this tag.

Copy link

🍱 You can preview the tagging presets of this pull request here.

Copy link
Collaborator

@Zverik Zverik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Translator's Office" would be a better name, but idk. Seems fine to me.

@Zverik Zverik requested a review from tyrasd July 26, 2024 13:04
@kjonosm
Copy link
Contributor

kjonosm commented Jul 26, 2024

image

@tordans
Copy link
Collaborator

tordans commented Jul 29, 2024

A few research notes:

Icon:

Fields language

Fields general

Testing
Ideally lets add the testing notes as described in https://github.com/openstreetmap/id-tagging-schema/pull/1239/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35R37-R70 to have a nice overview of things…

@deevroman
Copy link
Contributor Author

Fields language

It seems to me that we should not focus on this key yet, since it is difficult to implement it due to the suffix of the language. At the same time, it was used only 26 times: https://overpass-turbo.eu/s/1OSO

=> Lets check if those all fit and look at a few examples

It seems to look normal

Search example:

translation.mp4

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tordans tordans merged commit e25f91e into openstreetmap:main Aug 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants