Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust parking suggestions: promote street_side to reflect usage #1326

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

Nekzuris
Copy link
Contributor

Description, Motivation & Context

The usage of Street-Side parking has greatly increased, but it was still ranked very low in the suggestions.

Related issues

Closes #1325

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:parking

Relevant tag usage stats:
https://taginfo.openstreetmap.org/keys/parking#values
https://taghistory.raifer.tech/#***/parking/lane&***/parking/street_side

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 You can preview the tagging presets of this pull request here.

@Nekzuris
Copy link
Contributor Author

Test-Documentation

Before & After
ba

@maro-21
Copy link

maro-21 commented Aug 30, 2024

It should be on the second position. The order of the list should be I think the same as in:
https://taginfo.openstreetmap.org/keys/parking#values

@tordans
Copy link
Collaborator

tordans commented Aug 31, 2024

I am happing with merging the change. I think street side and roadside lane should be next to eachother so people research which to pick

https://wiki.openstreetmap.org/wiki/Tag:parking%3Dlane


Another improvement would be to add more help text right in iD, like with the strings description field.
More on that in https://github.com/ideditor/schema-builder/pull/152/files and

"aerial": {
"title": "Aerial",
"description": "Designed to be visible from the air."
},
is an example. Especially for lane and street_side those inline text would help some users, I think. They are pretty hard to discover ATM because they are not visible by default.


A nice follow up would be to add icons to the most important options, like we have for crossings.

It might be possible to reuse some from StreetComplete, but the need to be simplified I think – see zlant/parking-lanes#69

The schema is https://github.com/ideditor/schema-builder?tab=readme-ov-file#icons

@tordans tordans merged commit 65d4d70 into openstreetmap:main Aug 31, 2024
5 checks passed
@Nekzuris Nekzuris deleted the patch-1 branch August 31, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parking lane and street side should be inverted
3 participants