Remove regional restriction for Footwear Decontamination Station preset #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍱 You can preview the tagging presets of this pull request here. |
k-yle
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Regarding the iD warning - this seems like a bug that should be fixed, regardless of whether this PR is accepted. Right now, it's not allowed as a point nor an area 😆
The parent preset (man_made=*) is supposed to allow any geometry:
id-tagging-schema/data/presets/man_made/_yes.json
Lines 8 to 13 in 6d86393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation & Context
This will prevent iD from erroneously flagging points tagged with
man_made=footwear decontaminationas invalid.These stations are pretty common at trailheads in the PNW
I also added 'boot brush' as a term