Add drinking_water to moreFields for campsite #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `toilets` and `shower`, `drinking_water` would ideally be mapped as a separate node for campsites. However, including this field in the main object is still important to mark sites which do not have drinking water—it's difficult to place a node for a feature that doesn't exist—as well as when the mapper doesn't have time or enough resources to place a drinking water source that does exist as a separate feature.
|
This looks like a good edit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
toiletsandshower,drinking_waterwould ideally be mapped as a separate node for campsites. However, including this field in the main object is still important to mark sites which do not have drinking water—it's difficult to place a node for a feature that doesn't exist—as well as when the mapper doesn't have time or enough resources to place a drinking water source that does exist as a separate feature.