Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer=1 to building=roof preset #227

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Conversation

karsonkevin2
Copy link
Contributor

@karsonkevin2 karsonkevin2 commented Aug 21, 2021

Building=roof is used to denote a structure which is just a roof, passage underneath this roof via foot or car is possible.
https://wiki.openstreetmap.org/wiki/Tag:building%3Droof

It is pretty typical that their might be a highway=service &service=drive-through or a highway=footway passing underneath the roof. With the current roof preset, this leads to conflict as the roof and highways default to layer=0. In essentially all cases, the roof should be layer=1 or a higher layer if necessary. Defaulting to layer=1 for roof objects represents this reality.

Currently, 43% of roofs include layer=*, which would have to have been manually entered.
https://taginfo.openstreetmap.org/tags/building=roof#combinations

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change this to use the addTags syntax for this? Here's an example. Otherwise a roof with, say, layer=2 would not match the preset anymore.

@tyrasd tyrasd added the enhancement New feature or request label Dec 13, 2021
Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants