-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change default highway value for golf cart paths to "path" #327
Conversation
@1ec5, @matkoniecz: what do you think about this approach? |
Sadly, I am unfamiliar with cart paths so in this case I cannot offer guidance (I learned about them via gravitystorm/openstreetmap-carto#3734 - see especially gravitystorm/openstreetmap-carto#3734 (comment) ) |
Very strong +1 for this.
That said, |
Just so we're all on the same page and speaking honestly about how we got here.. The golf mappers originally proposed dedicated It was the osm-carto folks who got upset about this (once people started requesting that these paths get rendered) and insisted that we switch to using |
I feel your pain on that one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix – I think it’s important to minimize the risk of large vehicles traveling over these paths. highway=path
follows the principle of least surprise (by adopting an unsurprisingly chaotic tag).
If I recall correctly, highway=path
was relatively commonly used for golf cart paths in the U.S. prior to openstreetmap/iD#5862. I mentioned it in passing in gravitystorm/openstreetmap-carto#3734, but I don’t recall why the preset wound up with highway=service
instead of highway=path
when it became clear that some highway=*
value was needed. Based on the response to chadrockey/TGC-Designer-Tools#64, it’s likely that golf mappers will adhere to whatever this preset uses without edit-warring, as long as the preset retains golf=cartpath
.
Note that the golf=path
preset is very similarly tagged as highway=path
foot=designated
. As things stand, this will result in many non-golf-specific renderers giving both kinds of paths the same appearance. Consider using highway=footway
for that preset.
Do we need to introduce any deprecations for the older tagging scheme being replaced here?
My recollection was that their proposal was documented on the wiki (at least as a proposal).
I looked but haven’t been able to find a formal proposal from that time, unfortunately. There were a lot of parallel discussions at the time.
Later on, the discussions in #48 and elsewhere led to a proposal for highway=golf_cart_path
, which would make golf=cartpath
redundant. An RFC went out for that proposal in 2020, kicking off lots of discussion and back-and-forth over the optimal primary feature tag. It would be premature to adopt the proposal in its current form, since existing renderers wouldn’t recognize highway=golf_cart_path
at all. However, I think the mailing list and wiki discussions garnered sufficient support for the idea of some highway
value other than service
.
The commit openstreetmap/iD@df7a2f9 that closed openstreetmap/iD#6165 contained:
So mappers always did have this choice of which one to use. |
This PR would modify the latter to use |
openstreetmap/iD#5862 (comment) indicates that the purpose of these was for multiuse situations, like where the golf carts are expected to be driving through a parking lot or service area:
(they originally were proposing |
Ok I'm doing way more digging into this history of this than I'd like to, but the reason for this is because I know we had this correct back in openstreetmap/iD@e045c0f and it got messed up somewhere along the way, I guess here: openstreetmap/iD@df7a2f9 The intent of these presets was:
I remember having a lot of discussion with Chad about what he wanted these for. I even drew an icon for it. |
Oof, so this preset basically got conflated with the normal “Golf Cartpath” preset. That would explain all the problematic The case where golf carts can drive on actual service roads sounds like a good fit for the Access field rather than a separate preset. Since the last time these presets were modified, As long as we restore the golf cart path/service road combination in the form of an expanded Access field, it should be safe to revert the plain “Golf Cart Path” preset to |
and show the access field (as for all highway based presets), so users can set respective further access details
and use highway=footway for walking paths
Ok, I didn't know that these were three presets originally. I have solved the issue of not being able to easily map "multipurpose" service+cartpaths by adding a field for the highway tag for golf cartpaths where one can choose between a "cartpath" (the default) and "service road". This has the side benefit that manually entered highway values (e.g. `residential) will also be recognized. |
This is to fix #48:
I went with the approach to just use
highway=path
(+golf_cart=designated
) because it: avoids explicitly adding an implicit access restriction and is similar to the well established tagging scheme for multi-use paths (such as foot+bike paths), as well as the correspondinggolf=path
preset.This PR also activates the access field, so users can set see and set further access information.