Add some more values to beauty=* #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some frequent non-ambigous values from [taginfo](https://taginfo.openstreetmap.org/keys/?key=beauty#values) and [wiki](https://wiki.openstreetmap.org/wiki/Key:beauty).
see https://wiki.openstreetmap.org/wiki/Key%3Abeauty: * use descriptions from wiki * waxing has similar number of uses as the other new values (see https://taginfo.openstreetmap.org/keys/beauty#values) * the value "hair" is not documented on wiki (probably because of the overlap with shop=hairdresser)
|
see my tweaks in 7ef7f8d: what do you think? |
|
Yeah, looks good. |
|
Although I'd argue "Spa" is a wide-understood term that people would search for. |
I had always associated the term "spa" exclusively with thermal baths (see wikipedia: https://en.wikipedia.org/wiki/Spa) to be honest. Perhaps "Spa Treatment" would be a better description instead of "Hydrotherapy" (but on the other hand, spa treatment can apparently be used for basically any beauty treatment)? |
1ec5
reviewed
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some frequent non-ambigous values from taginfo and wiki.