Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the multipolygon relation type searchable #481

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Jun 1, 2022

When you create a new relation, it's very hard to find the option for Multipolygon.

  • The first issue is you need to scroll down a lot to find the most common option.
  • The second issue is Multipolygon is the only relation preset that can't be found by searching. This is annoying if you're using keyboard shortcuts to navigate around.

This PR fixes both issues. Multipolygon is now treated like any other relation preset.

Current behaviour:

@westnordost
Copy link
Contributor

westnordost commented Jun 1, 2022

That it is currently not searchable must have been deliberate. Did you search this issue tracker / commit history for the reason this was added as not searchable? (And if yes, why do you think this reason does not hold anymore?)

@k-yle
Copy link
Collaborator Author

k-yle commented Jun 1, 2022

unsearchable: true was added 9 years ago in openstreetmap/iD@4bdd49b5, so that it doesn't appear alongside area-presets like building. unsearchable isn't needed if we make this preset only apply to relations. I've tested this in an old version of iD and it works well

@tyrasd tyrasd merged commit 61d6525 into openstreetmap:main Jun 13, 2022
@k-yle k-yle deleted the multipolygon-searchable branch June 14, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants