Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset amenity=driver_training #499

Merged
merged 13 commits into from
Sep 9, 2022
Merged

Add preset amenity=driver_training #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
35dc2ad
Create driver_training.json
SteveLz Jun 16, 2022
f96dd90
Update driver_training.json
SteveLz Jun 17, 2022
5b858f7
Update data/presets/amenity/driver_training.json
SteveLz Jun 17, 2022
ef12f65
Update data/presets/amenity/driver_training.json
SteveLz Jun 17, 2022
840d611
Update driver_training.json
SteveLz Jun 17, 2022
ecc465c
Create license_classes.json
SteveLz Jun 17, 2022
8ea93c8
Update data/fields/license_classes.json
SteveLz Jun 17, 2022
d426a8b
Update data/presets/amenity/driver_training.json
SteveLz Jun 17, 2022
a6502fe
Update data/fields/license_classes.json
SteveLz Jun 17, 2022
6eacb64
fix typo / json syntax
tyrasd Jun 17, 2022
de7cc95
Update driving_school.json
SteveLz Jun 18, 2022
0782264
Merge branch 'main' into patch-1
tyrasd Sep 9, 2022
863d1d9
fix syntax error
tyrasd Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions data/fields/license_classes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"key": "license_classes",
"type": "semiCombo",
"label": "Driving License Classes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Driving license” is understandable but not quite correct in any dialect of English. The source string should be changed to “driver’s license”, per American English. (The British English term would be “driving licence”; the Canadian, Australian, and New Zealand English localizations would have their own translations as well.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that, “driver’s license classes” is confusing in the context of a preset for driver training. At first, when I tried to translate this string, I thought it meant “classes for obtaining a driver’s license”, but this key actually means “classes of driver’s license”. On the Driver Training Grounds preset, a user might end up leaving this field blank because no classes are taught there. I’d suggest changing this string to “License Classifications” or “Classes of Driver’s License” to avoid confusion.

Copy link
Member

@tyrasd tyrasd Sep 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the spelling/wording in 7f0b1e4

}
34 changes: 34 additions & 0 deletions data/presets/amenity/driver_training.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"icon": "maki-car",
"fields": [
"name",
"operator",
"operator/type",
"address",
"opening_hours"
],
"moreFields": [
"license_classes",
tyrasd marked this conversation as resolved.
Show resolved Hide resolved
"email",
"fax",
"opening_hours/covid19",
"payment_multi",
"phone",
"website",
"wheelchair"
],
"geometry": [
"point",
"area"
],
"tags": {
"amenity": "driver_training"
},
"name": "Driver Training Grounds",
"aliases": [
"Driving Safety Center"
],
"terms": [
"Driving School"
SteveLz marked this conversation as resolved.
Show resolved Hide resolved
]
}
3 changes: 2 additions & 1 deletion data/presets/amenity/driving_school.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,15 @@
"operator",
"operator/type",
"address",
"building_area_yes",
"building_area",
"opening_hours"
],
"moreFields": [
"email",
"fax",
"gnis/feature_id-US",
"level",
"license_classes",
"opening_hours/covid19",
"payment_multi",
"ref/FR/siret-FR",
Expand Down