Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the website tag to be used on any feature #503

Merged
merged 4 commits into from
Jun 17, 2022

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Jun 17, 2022

You can use fields like image=*, wikidata=*, and wikimedia_commons=* on any preset, so I think it's also logical to allow website=* to be used on any preset.

A lot of things are not significant enough to be on wikidata, but they do have their own website.

@tyrasd tyrasd added the enhancement New feature or request label Jun 17, 2022
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds reasonable to me. 👍

But we would need to remove the field from all presets which currently include this one as a moreFields field, as that information will be made obsolete by this change.

//edit: this is the list of presets (tags) which currently include the website field as as moreFields (click the triangle to expand):

{"attraction":"*"}
{"aeroway":"aerodrome"}
{"amenity":"embassy"}
{"amenity":"animal_boarding"}
{"amenity":"animal_breeding"}
{"amenity":"animal_shelter"}
{"amenity":"arts_centre"}
{"amenity":"bank"}
{"amenity":"bar"}
{"amenity":"bicycle_rental"}
{"amenity":"boat_rental"}
{"amenity":"bureau_de_change"}
{"amenity":"car_pooling"}
{"amenity":"car_rental"}
{"amenity":"car_sharing"}
{"amenity":"car_wash"}
{"amenity":"casino"}
{"amenity":"cinema"}
{"amenity":"clinic"}
{"amenity":"courthouse"}
{"amenity":"crematorium"}
{"amenity":"dentist"}
{"amenity":"dive_centre"}
{"amenity":"doctors"}
{"amenity":"dojo"}
{"amenity":"driving_school"}
{"amenity":"fire_station"}
{"amenity":"food_court"}
{"amenity":"fuel"}
{"amenity":"grave_yard"}
{"amenity":"hospital"}
{"amenity":"ice_cream"}
{"amenity":"kindergarten"}
{"amenity":"language_school"}
{"amenity":"library"}
{"amenity":"love_hotel"}
{"amenity":"marketplace"}
{"amenity":"monastery"}
{"amenity":"money_transfer"}
{"amenity":"motorcycle_rental"}
{"amenity":"music_school"}
{"amenity":"nightclub"}
{"amenity":"parking"}
{"amenity":"payment_centre"}
{"amenity":"pharmacy"}
{"amenity":"place_of_worship"}
{"amenity":"planetarium"}
{"amenity":"police"}
{"amenity":"polling_station"}
{"amenity":"post_depot"}
{"amenity":"post_office"}
{"amenity":"prep_school"}
{"amenity":"prison"}
{"amenity":"pub"}
{"amenity":"public_bath"}
{"amenity":"ranger_station"}
{"amenity":"recycling","recycling_type":"centre"}
{"amenity":"refugee_site"}
{"amenity":"social_centre"}
{"amenity":"social_facility"}
{"amenity":"townhall"}
{"amenity":"toy_library"}
{"amenity":"vehicle_inspection"}
{"amenity":"veterinary"}
{"amenity":"waste_transfer_station"}
{"barrier":"border_control"}
{"barrier":"toll_booth"}
{"building":"commercial"}
{"building":"office"}
{"club":"*"}
{"emergency":"ambulance_station"}
{"golf":"clubhouse"}
{"highway":"rest_area"}
{"highway":"toll_gantry"}
{"historic":"memorial"}
{"landuse":"allotments"}
{"landuse":"aquaculture"}
{"landuse":"cemetery"}
{"landuse":"commercial"}
{"landuse":"construction"}
{"landuse":"farmland"}
{"landuse":"farmyard"}
{"landuse":"forest"}
{"landuse":"garages"}
{"landuse":"greenhouse_horticulture"}
{"landuse":"harbour"}
{"landuse":"industrial"}
{"landuse":"landfill"}
{"landuse":"military"}
{"landuse":"orchard"}
{"landuse":"plant_nursery"}
{"landuse":"quarry"}
{"landuse":"recreation_ground"}
{"landuse":"religious"}
{"landuse":"retail"}
{"landuse":"vineyard"}
{"leisure":"amusement_arcade"}
{"leisure":"bandstand"}
{"leisure":"beach_resort"}
{"leisure":"bird_hide"}
{"leisure":"bowling_alley"}
{"leisure":"common"}
{"leisure":"dance"}
{"leisure":"dance","dance:teaching":"yes"}
{"leisure":"disc_golf_course"}
{"leisure":"garden"}
{"leisure":"golf_course"}
{"leisure":"horse_riding"}
{"leisure":"ice_rink"}
{"leisure":"marina"}
{"leisure":"miniature_golf"}
{"leisure":"nature_reserve"}
{"leisure":"park"}
{"leisure":"resort"}
{"leisure":"sauna"}
{"leisure":"sports_centre"}
{"leisure":"stadium"}
{"man_made":"lighthouse"}
{"man_made":"monitoring_station"}
{"man_made":"observatory"}
{"man_made":"survey_point"}
{"man_made":"video_wall"}
{"man_made":"wastewater_plant"}
{"man_made":"works"}
{"place":"city_block"}
{"place":"city"}
{"place":"hamlet"}
{"place":"locality"}
{"place":"neighbourhood"}
{"place":"quarter"}
{"place":"square"}
{"place":"suburb"}
{"place":"town"}
{"place":"village"}
{"public_transport":"station"}
{"route":"ferry"}
{"telecom":"data_center"}
{"tourism":"alpine_hut"}
{"tourism":"aquarium"}
{"tourism":"artwork"}
{"tourism":"camp_site"}
{"tourism":"caravan_site"}
{"tourism":"gallery"}
{"tourism":"information","information":"office"}
{"tourism":"museum"}
{"tourism":"picnic_site"}
{"tourism":"trail_riding_station"}
{"tourism":"zoo"}
{"waterway":"boatyard"}
{"waterway":"dam"}
{"waterway":"fuel"}

@tyrasd tyrasd self-requested a review June 17, 2022 15:25
@tyrasd tyrasd merged commit 0d4f3da into openstreetmap:main Jun 17, 2022
@k-yle k-yle deleted the website-on-everything branch December 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants