-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parking=street_side #73
Conversation
Note: "parking:street_side" should be changed to "parking:orientation" after it has been renamed during the implementation of the proposal (see footnote 1 on proposal page: https://wiki.openstreetmap.org/wiki/Proposed_features/parking%3Dstreet_side). |
61845a3
to
324e478
Compare
@SupaplexOSM Oh that's right! Commit amended. |
324e478
to
9c0bf3f
Compare
Wow! I was just going to add this. Nice work! |
I fully support We already have separate presets for Multilevel Parking Garage and Underground Parking (for me not necessary either), but we don't have it for e.g. parking=surface - the most common value. One preset, "Parking Lot" would be enough. Then a user can choose the type of the parking. The reason for this is that after typing "parking" (at least in my language) I would like to see the main presets:
But what I see is:
If we add another one, the main preset, "Parking Lot" will be even lower. But it should be on the first position becasue it's one of the most popular and basic preset/tag on OSM.
The answer to both question is: because there is no data item, like this: https://wiki.openstreetmap.org/wiki/Item:Q7598 |
That sounds like an issue with priorities in sorting. I agree that the generic parking preset should show up on top. I think there is some support in the tagging language that allows for some results to be prioritised, but I'm not knowledgeable enough about that. It's better to open a separate issue for the sorting problem to keep this PR topical though. |
@quincylvania Any idea how I can address the three bullet-points in the OP? |
Could it be addressed in some ways by using a |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid change, street-side parking are starting to be used intensively.
I just double checked locally (built this code and pushed to the iD) and I am confirming that appropriate wiki page is being linked in the iD for amenity/parking/street-side preset.
source_strings.yaml should be updated, thought I don't consider this a pr blocker (usually this is done via: npm run build)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of copyediting:
Adds a preset for street-side parking¹. 1: https://wiki.openstreetmap.org/wiki/Proposed_features/parking%3Dstreet_side
9c0bf3f
to
0f72c96
Compare
Done. |
Note for a follow-up PR: in the year since I've submitted this PR
|
Adds a preset for street-side parking.
The proposal for
parking=street_side
has been approved, and the tag is in use. This PR adds the preset for the explicitly mapped variant. The implicitly mapped variant uses theparking:lane
tag on the highway itself instead of mapping the areas separately and will be offered via a separate PR later.This seems to work, but when I preview this in iD I see this:
The wiki-link for the preset seems to be
Key:parking
rather thanTag:parking=street_side
. Any idea why?The label in the preset for
parking:street_side
is justparking/street_side
. How do I set the label to the value oflabel
indata/fields/parking/street_side.json
?No wiki documentation for the field
parking:street_side
either, but that may because the page has only recently been created.Are there more files I should edit?