Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for operator:wikidata #769

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kjonosm
Copy link
Contributor

@kjonosm kjonosm commented Jan 31, 2023

See #168

@kjonosm kjonosm changed the title Create wikidata.json Add field for operaator:wikidata Jan 31, 2023
@kjonosm kjonosm changed the title Add field for operaator:wikidata Add field for operator:wikidata Jan 31, 2023
@tyrasd tyrasd marked this pull request as draft February 1, 2023 10:43
@tyrasd tyrasd added the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Feb 1, 2023
@tyrasd
Copy link
Member

tyrasd commented Feb 1, 2023

This PR only defines the field, but does not add it to any preset. Without adding it to any preset, the field would be essentially useless.

Did you intend to add this field to any preset which includes the operator field? That would have the major downside of being a lot of effort to change, as it involves changing hundreds of presets. I think we should think about a better solution, e.g. involving an improved "wikidata" field which can directly work on a tag-triplet, e.g. here operator + operator:wikidata + operator:wikipedia. That would require some changes to the schema, however.

@kjonosm
Copy link
Contributor Author

kjonosm commented Feb 1, 2023

Did you intend to add this field to any preset which includes the operator field?

@tyrasd: That was the idea following the already featured subject:wikidata field. However, not to all presets with operator=* info but only those where operator:wikidata=* is commonly used, see NSI for reference. If you don't consider merging this pull request (and others adding *:wikidata fields) please let me know and I am happy to delete them.

@matkoniecz
Copy link
Contributor

matkoniecz commented Feb 5, 2023

Without adding it to any preset, the field would be essentially useless.

What about objects where this tag was already added?

@kjonosm
Copy link
Contributor Author

kjonosm commented Feb 12, 2023

What about objects where this tag was already added?

The field still needs to be added to the respective presets...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-field waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants