Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make barrier=log preset searchable #822

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Conversation

matkoniecz
Copy link
Contributor

fixes #615

warning: untested

that is the worst part of json, lack of trailing comma
@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-822--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@matkoniecz
Copy link
Contributor Author

maybe some icon would be nice

curiously, it works for lines but not for standalone points

@tyrasd
Copy link
Member

tyrasd commented Mar 18, 2023

curiously, it works for lines but not for standalone points

that's because the preset only defines line and vertex as geometry types:

    "geometry": [
        "vertex",
        "line"
],

I guess we could also add the point type to this preset.

@matkoniecz
Copy link
Contributor Author

not entirely sure is it making sense as standalone point - I was more surprised that lines are allowed, but apparently there is some micromapping of barrier=log placed along paths/roads

@tyrasd
Copy link
Member

tyrasd commented Mar 21, 2023

not entirely sure is it making sense as standalone point

right… I was initially thinking that it could make sense in some edge cases (e.g. when a fallen tree is blocking an polygon feature like a waterway, but I guess for these occasions probably the line geometry should be used instead). I'll revert the addition of the point type

@tyrasd tyrasd merged commit 1fed613 into openstreetmap:main Mar 24, 2023
@matkoniecz matkoniecz deleted the patch-7 branch April 14, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make barrier=log preset searchable
2 participants