Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional synonym and a better name for gynecologist #873

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

matkoniecz
Copy link
Contributor

@matkoniecz matkoniecz commented Apr 18, 2023

fixes #789

Per #789 (comment)

After changing it, you’d need to run npm run build to update the localizable string table.

should I do it as a part of PR?

@matkoniecz
Copy link
Contributor Author

npm run build fails for me, see

npm run build

> @openstreetmap/id-tagging-schema@6.2.0-dev build
> node scripts/build.js

file:///home/mateusz/Documents/install_moje/OSM_software/id-tagging-schema/node_modules/@ideditor/schema-builder/lib/build.js:417
    if (field.locationSet?.include) {
                          ^

SyntaxError: Unexpected token '.'
    at Loader.moduleStrategy (internal/modules/esm/translators.js:81:18)

I will try figuring out why, but it seems local breakage and failure to install proper node version - not causing problems with this PR

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-873--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Apr 18, 2023
@tyrasd
Copy link
Member

tyrasd commented Apr 18, 2023

npm run build fails for me

Which version of nodejs do you run? You need at least nodejs version 14 to use the ?. (optional chaining) operator.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Apr 18, 2023

node -v gives v13.14.0 - that explains things

matkoniecz and others added 2 commits April 18, 2023 16:24
Co-authored-by: Martin Raifer <martin@raifer.tech>
@tyrasd
Copy link
Member

tyrasd commented Apr 18, 2023

perfect, thanks!

btw: strictly speaking, it is now really necessary anymore to run npm run build for a PR like this one, as we have a bot which does this automatically (if necessary) after each merge/push to the main branch, like this example commit: ad4dbd4. But I do usually run it manually myself and is also a thing I still appreciate in PRs, as it keeps the commit history of the project a little bit more tidy overall. ☺️

@tyrasd tyrasd merged commit c670cd9 into openstreetmap:main Apr 18, 2023
@matkoniecz matkoniecz deleted the patch-1 branch April 18, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional synonym and maybe a better name for gynecologist
2 participants