-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'cyclestreet'-field #888
Conversation
🍱 Preview the tagging presets of this pull request here: https://pr-888--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Yes, it would be a good idea to limit this field to the countries that have accepted this key, to avoid exacerbating the existing confusion between this key and id-tagging-schema/data/fields/expressway-US.json Lines 5 to 9 in 7617c45
|
Thanks for the hint, I've added an include-set (and ran the linter in the meantime). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a cyclestreet guaranteed to be a highway=residential
, or can it also be on a road classified differently, like unclassified
or service
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unclassified-highway copies all 'extra'-tags from residential. This new field should thus appear at unclassified
as well.
For the other types, I ran the numbers with a global overpass-entry and a little script:
Amount | highway-type |
---|---|
7864 | residential (71.2%) |
1378 | unclassified (12.4%) |
806 | tertiary (7.3%) |
339 | living_street (3%) |
152 | secondary |
139 | service |
115 | pedestrian |
79 | cycleway |
53 | track |
33 | primary |
25 | footway |
21 | path |
9 | null |
7 | construction |
3 | tertiary_link |
3 | proposed |
2 | primary_link |
1 | street_lamp |
1 | secondary_link |
I have to admit I'm a bit surprised by the high amount of tertiary roads in there, I suspected them to be less.
Also, it doesn't really make sense on some values, at least not from the perspective of a Belgian ;) (e.g. primary or 'street_lamp')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks a lot for this PR. I noticed a couple of things:
- Starting with a small technicality: We use the convention that regional fields should use a file name suffix indicating which countries it applies to. Could you please rename it to
cyclestreet-BE-NL.json
? - Germany does not use the
cyclestreet
tag, but instead thebicycle_road
. Could you please removeDE
from thelocationSet
here? - In Finland, both
cylcestreet
andbicycle_road
are currently used very rarely (only on 6 km and 7 km, respectively). The OSM wiki lists the corresponding road sign on the pages for both tags, which is confusing. If the description is correct, the more matching tag seems to becyclestreet
, but it would be nice if this could be clarified before we include it in the presets. For now, we could omitFI
. - I think the use on
highway=tertiary
roads is not unreasonable for a street which has some local importance in the road network, but still gives preference to cyclists. I found these to be somewhat common in city centers, like in this example. Could you add the field also to the preset forhighway=tertiary
? - Similarly, the combined use with
highway=living_street
does also seem to be possible (e.g. when a larger cyclestreet-zone contains individual roads which are signposted as living streets). I'd be inclined to allow the field also in the living street preset.
One additional tricky thing is that we eventually would also like add a field for the //edit: ok, after reading up on this the wiki again, I would tend to agree with the author(s):
This would allow us to use the same field label for both this field and the (future) one for the |
Hey @tyrasd , I have renamed the file and added it to 'tertiary' and 'living_street'. There is - at least in Belgium - a meaningful difference between 'cyclestreet' and 'bicycle_road'. A cyclestreet is a street where cars are allowed, but may not overtake. This is often an already existing road where cars are slowed down a bit. As I interpreted the wiki, a bicycle_road resembles what we would tag with 'cycleway', a purpose-built, wide road where cars are not allowed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @pietervdvn, however it seems like the cyclestreet-BE-NL.json
is missing in the last commit of this PR. 😉
For a bit of additional context: In the case of Germany, most Anyway, from the iD editor point of view, it is fine that Belgium and Netherlands uses a dedicated / more specialized tag. I'm happy to support these regional variations. I was initially only a bit worried that we might have to support both tags in parallel in some countries. |
Derp, I've actually added it now. |
Thanks for merging! |
Thanks for the PR. 🙇 FYI: I've now also added a field for |
Cyclestreets are a special legal designation in some countries, where motorized vehicles are not allowed to overtake cyclists (see the wiki page).
This PR adds a 'cyclestreet'-field and adds it as extra option to residential (and thus also unclassified) roads
This type of road is mostly in use in Belgium, the Netherlands, Germany and Finland. Ideally, this field is thus only an option in these countries but I couldn't figure out how to trigger this.